fix: fixing syncing stuck issue #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 83.05% 83.13% +0.07%
==========================================
Files 171 171
Lines 7951 7956 +5
==========================================
+ Hits 6604 6614 +10
+ Misses 1031 1027 -4
+ Partials 316 315 -1 |
b00f
approved these changes
Oct 1, 2023
themantre
force-pushed
the
fixing-syncing-issue
branch
from
b924c43
to
6733d6f
Compare
b00f
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the syncing issues at the Pre-Testnet-2.
The problem arises because some received blocks have stripped public keys, and validating blocks will encounter errors.
It is fixed by validating each new block after committing the previous block and indexing the public keys.