feat: implementing pip-15 #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
+ Coverage 83.23% 83.32% +0.09%
==========================================
Files 170 171 +1
Lines 8575 8673 +98
==========================================
+ Hits 7137 7227 +90
- Misses 1099 1104 +5
- Partials 339 342 +3 |
amirvalhalla
changed the title
b00f
requested changes
Dec 10, 2023
b00f
reviewed
Dec 14, 2023
b00f
requested changes
Dec 14, 2023
|
Testing these change is super important. Please make sure all functionalities is tested properly |
b00f
requested changes
Dec 25, 2023
b00f
requested changes
Dec 27, 2023
There was a problem hiding this comment.
@amirvalhalla Thanks.
It is almost done, you did amazing Job.
b00f
requested changes
Dec 30, 2023
b00f
requested changes
Dec 31, 2023
There was a problem hiding this comment.
Thanks @amirvalhalla. It is Almost done, just small changes before merging.
| } | ||
|
|
||
| as.addrCache.Add(addr, acc) | ||
| return acc, nil |
There was a problem hiding this comment.
Here, I still feel that we need to review it again. We are returning an account pointer here, and it can be changed, which could potentially manipulate the cache.
b00f
approved these changes
Dec 31, 2023
Ja7ad
added a commit
to pactus-project/PIPs
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements PIP-15.