Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementing pip-15 #843
feat: implementing pip-15 #843
Changes from 8 commits
4e04454
13902f9
6630b6f
ec8a222
d9c4cdd
c76d802
b323db9
b45cb1b
c17a629
8ca67d3
10a98e1
ac96375
9d8cef3
fd5b778
0260d88
7d0ea22
aaaeeb6
887eeca
337f579
e86ac46
cffe24f
4591349
d297c9a
4f0b61c
bfb3991
d00831f
d6d19b8
ef32853
fbdc2f0
c6c05bc
9a2a1dc
c9d300c
254ff40
296a5b4
0a4274b
2e6d417
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks dangerous to me. Why not clone it? Perhaps the tests should be refined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I still feel that we need to review it again. We are returning an account pointer here, and it can be changed, which could potentially manipulate the cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this line removed?
We need to make sure
accInCache
is equal toaccInStore
.