Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Swift-UI Introspect to v1.1.1 to fix the watchOS previe… #12

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

Narsail
Copy link
Contributor

@Narsail Narsail commented Jan 3, 2024

Update Swift-UI Introspect to v1.1.1 to fix the watchOS preview bug if the library is part of the iOS Companion.

I experienced an issue using your great library (thanks for the easy support of custom keyboards) when previewing my watchOS app. Apparently, Swift-UI Introspect is causing failures for watchOS in versions < 1.1.1

I tested the updated with xcodebuild -scheme CustomKeyboardKit -destination 'generic/platform=iOS' and it was building successfully.

…w bug if the library is part of the iOS Companion.
@paescebu
Copy link
Owner

paescebu commented Jan 3, 2024

@Narsail Thanks for taking your time and your contribution!

I need some more details to understand the issue and correction better.

What issues were you exactly facing?
Did I understand correctly that the problem was that the CustomKeyboardKit package forced SPM to use the older version of SwiftUI introspect (0.7.0), which you used also independently from CustomKeyboardKit in your project. And that independent use of SwiftUI Introspect caused issues due to being outdated?

What was the reason you added an explanation how to build the package from the command line into the Readme? :)
Is that something people or I should do or be aware of for some reason?

@Narsail
Copy link
Contributor Author

Narsail commented Jan 3, 2024

@paescebu Not exactly. Your library is the only one of my dependencies that uses SwiftUI Introspect. You can read more about the issue here: Apple Developer Forum and in the Swift UI Introspect PR fixing it.

It is enough to have Swift-UI Introspect be installed as a dependency of iOS only, which will cause issues with watchOS previews (building the actual binary for deployment is unaffected).

W.r.t. to the readme addition, the error I ran into when using swift build wasn't descriptive enough so I had to do some googling to figure out that you have to use xcodebuild for iOS only swift packages. Hence the addition to save others valuable time if they want to build your package.

@paescebu
Copy link
Owner

paescebu commented Jan 3, 2024

@Narsail Awesome thanks for the clarifications. Now I understand.

So my suggestions:

  • bumping up the version of the SwiftUI Introspect library is totally fine with me 👌
  • I would omit the Readme entry though, as I am not sure if this an issue people actually run into. I doubt hat people try to build CustomKeyboardKit separately from the command line. I think it's the least probable way of how the package is being used. This usually just resides in an Xcode project and Xcode handles the rest when building for a host project. I'd prefer to keep the Readme short and concise with the most relevant info only. So people don't get fed up reading it :)

What do you think?

@Narsail
Copy link
Contributor Author

Narsail commented Jan 3, 2024

Yeah, I'm good with that. Removed the entry 👍

@paescebu paescebu merged commit 44b0f20 into paescebu:master Jan 3, 2024
@paescebu
Copy link
Owner

paescebu commented Jan 3, 2024

@Narsail awesome stuff! Thank you for keeping it up to date.

Kind regards and have a great year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants