-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watchOS preview build issue #380
Fix watchOS preview build issue #380
Conversation
Added os type check to all files
Additional description: https://developer.apple.com/forums/thread/731732 |
Thanks for your PR. Is there any way we could add a CI check to make sure this doesn't break with future iterations? |
I'm not sure about this. I don't know if it is possible to "Build to Preview" from the command line to reproduce the problem. |
Okay I'll look into this. I wouldn't want to merge without some assurance from CI. I'll try my best to get it sorted asap. |
@davdroman You can mention me if you need some help with an example project to reproduce this. |
@sergeirr yes please, I'd certainly appreciate an example project. |
@davdroman This is the project https://github.com/sergeirr/WatchOSIntrospect
|
Thanks! This is very helpful to get going. |
For some reason Xcode watchOS SwiftUI preview attempts to build this package against watchOS SDK.
Fixed by adding os type check.
Tested with:
Fixes #111