Bump pipeline from 1.38.0 to 1.39.0 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paketo-bot
force-pushed
the
update/pipeline
branch
from
f466188
to
021a15c
Compare
paketo-bot
added
semver:patch
dmikusa
reviewed
May 13, 2024
Comment on lines
-5
to
+8
| GOOS="linux" GOARCH="amd64" go build -ldflags='-s -w' -tags osusergo -o "linux/amd64/bin/helper" "$GOMOD/cmd/helper" | ||
| GOOS="linux" GOARCH="arm64" go build -ldflags='-s -w' -tags osusergo -o "linux/arm64/bin/helper" "$GOMOD/cmd/helper" | ||
| GOOS="linux" GOARCH="amd64" go build -ldflags='-s -w' -tags osusergo -o linux/amd64/bin/main "$GOMOD/cmd/main" | ||
| GOOS="linux" GOARCH="arm64" go build -ldflags='-s -w' -tags osusergo -o linux/arm64/bin/main "$GOMOD/cmd/main" | ||
| GOOS="linux" GOARCH="amd64" go build -ldflags='-s -w' -o "linux/amd64/bin/helper" "$GOMOD/cmd/helper" | ||
| GOOS="linux" GOARCH="arm64" go build -ldflags='-s -w' -o "linux/arm64/bin/helper" "$GOMOD/cmd/helper" | ||
| GOOS="linux" GOARCH="amd64" go build -ldflags='-s -w' -o linux/amd64/bin/main "$GOMOD/cmd/main" | ||
| GOOS="linux" GOARCH="arm64" go build -ldflags='-s -w' -o linux/arm64/bin/main "$GOMOD/cmd/main" |
There was a problem hiding this comment.
I think this is a safe change.
When cgo is available, and the required routines are implemented in libc for a particular platform, cgo-based (libc-backed) code is used. This can be overridden by using osusergo build tag, which enforces the pure Go implementation.
So we were adding this to force using pure go, not cgo, but we are doing that for CI builds here so I think we should be safe. The only exception would be when building locally.
Now that we control build.sh in pipeline-builder, we may want to consider adding export CGO_ENABLED=0 to the build.sh script and removing it from CI so that things are more consistent outside of CI.
Bumps pipeline from 1.38.0 to 1.39.0. Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
paketo-bot
changed the title
paketo-bot
force-pushed
the
update/pipeline
branch
from
021a15c
to
9c94908
Compare
dmikusa
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps pipeline from
1.38.0to1.39.0.Release Notes
🐞 Bug Fixes
⛏ Dependency Upgrades
🚧 Tasks