Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use effect.NewExecutor use CommandExecutor instead #843

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Do not use effect.NewExecutor use CommandExecutor instead #843

merged 1 commit into from
Oct 4, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Oct 4, 2024

Summary

When running syft, do not use effect.NewExecutor which runs the command with a tty. This seems to cause an issue with syft (or possibly with our tty library pty), and in either case you end up with stray formatting characters even though we tell syft to be quiet. Using CommandExecutor is basically the same, but it doesn't run with a tty.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Do not use effect.NewExecutor use CommandExecutor instead
553b910 
When running `syft`, do not use effect.NewExecutor which runs the command with a tty. This seems to cause an issue with syft (or possibly with our tty library pty), and in either case you end up with stray formatting characters even though we tell syft to be quiet. Using CommandExecutor is basically the same, but it doesn't run with a tty.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Oct 4, 2024
@dmikusa dmikusa requested review from a team as code owners October 4, 2024 14:24
kevin-ortega
kevin-ortega approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@kevin-ortega kevin-ortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmikusa dmikusa merged commit 28c2f5a into main Oct 4, 2024
7 checks passed
@dmikusa dmikusa deleted the fix-chars branch October 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-ortega kevin-ortega kevin-ortega approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @kevin-ortega