Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use effect.NewExecutor use CommandExecutor instead #843

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Do not use effect.NewExecutor use CommandExecutor instead #843

merged 1 commit into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Do not use effect.NewExecutor use CommandExecutor instead 

    When running `syft`, do not use effect.NewExecutor which runs the command with a tty. This seems to cause an issue with syft (or possibly with our tty library pty), and in either case you end up with stray formatting characters even though we tell syft to be quiet. Using CommandExecutor is basically the same, but it doesn't run with a tty.

Signed-off-by: Daniel Mikusa <[email protected]>
    @dmikusa
    dmikusa committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    553b910 View commit details
    Browse the repository at this point in the history