-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Adding GitHub action to assign issues based on comment #29648
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9e05b04
CI: Adding GitHub action to assign issues based on comment
datapythonista ccf0d22
Typo
datapythonista 84acf9a
Update doc/source/development/contributing.rst
datapythonista 2213bce
Merge remote-tracking branch 'upstream/master' into assign_action
datapythonista 50b38e6
Merge branch 'assign_action' of github.com:datapythonista/pandas into…
datapythonista 2be96f1
Better documentation (splitting in several paragraphs)
datapythonista 457125c
Update doc/source/development/contributing.rst
datapythonista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: Assign | ||
on: | ||
issue_comment: | ||
types: created | ||
|
||
jobs: | ||
one: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: | ||
run: | | ||
if [[ "${{ github.event.comment.body }}" == "take" ]]; then | ||
echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" | ||
curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -d '{"assignees": ["${{ github.event.comment.user.login }}"]}' https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/assignees | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about
take-issue
orassign-issue
(then in theory could actually specify a username after)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the keyword, I found
take
the simplest option (thought of assign too, but I think it's easier to make typos, asign, assing...).I thought about adding a user after it, but we (maintainers/triagers) can already assign issues with GitHub UI. And I don't see regular users wanting to assign to someone else. And note that GitHub limits assignees to people who commented on the issue. That's the "fun" part, creating the comment with the take is what allows the action to assign to the commenter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k