Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Remove outdated docs about NumPy's broadcasting #55427

Merged
merged 1 commit into from
Oct 9, 2023
Merged

DOC: Remove outdated docs about NumPy's broadcasting #55427

merged 1 commit into from
Oct 9, 2023

Conversation

cobaltt7
Copy link
Contributor

@cobaltt7 cobaltt7 commented Oct 6, 2023

NumPy v1.25.0 removes the previosuly deprecated behavior of returning False when an array could not be broadcast. It now raises a ValueError, same as Pandas. numpy/numpy#22707
The Pandas documentation previously highlighted this discrepancy. However, since it now throws an error, it is causing building the documentation to fail.

I removed the mention of NumPy in this section since the behavior is mostly the same (NumPy still treats an array of one item as a scalar, while Pandas doesn't). Would it be preferable to mention that they act the same now?

@datapythonista datapythonista changed the title Remove outdated docs about NumPy's broadcasting DOC: Remove outdated docs about NumPy's broadcasting Oct 7, 2023
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @RedGuy12, thanks for taking care of this.

@mroeschke mroeschke added this to the 2.2 milestone Oct 9, 2023
@mroeschke mroeschke merged commit dc3035d into pandas-dev:main Oct 9, 2023
15 checks passed
@mroeschke
Copy link
Member

Thanks @RedGuy12

@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 2.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Nov 9, 2023
jorisvandenbossche pushed a commit that referenced this pull request Nov 9, 2023
…umPy's broadcasting) (#55896)

Backport PR #55427: DOC: Remove outdated docs about NumPy's broadcasting

Co-authored-by: cobalt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants