Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #55764 on branch 2.1.x (REGR: fix return class in _constructor_from_mgr for simple subclasses) #55892

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Backport PR #55764 on branch 2.1.x (REGR: fix return class in _constructor_from_mgr for simple subclasses) #55892

merged 1 commit into from
Nov 9, 2023

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #55764: REGR: fix return class in _constructor_from_mgr for simple subclasses

@lumberbot-app lumberbot-app bot added this to the 2.1.3 milestone Nov 9, 2023
@lumberbot-app lumberbot-app bot added Regression Functionality that used to work in a prior pandas version Subclassing Subclassing pandas objects labels Nov 9, 2023
@lithomas1
Copy link
Member

I think we might need the fix in #55885 for this.

@jorisvandenbossche
Copy link
Member

I think it is #55427 that needs to be backported

@jorisvandenbossche
Copy link
Member

Or both ;)

@jorisvandenbossche
Copy link
Member

Removed my temp commits again

@jorisvandenbossche jorisvandenbossche merged commit 4158666 into pandas-dev:2.1.x Nov 9, 2023
75 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version Subclassing Subclassing pandas objects
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@meeseeksmachine @lithomas1 @jorisvandenbossche @ivirshup