Implement --no-fast, --chroot, and caching/invalidation for golang tests
#6935
Assignees
Labels
Comments
|
Noting that another tack is to make minimize aware of target types that don't minimize properly and having it add in the closure of the calculated minimal cover for those target types. |
cosmicexplorer
added a commit
that referenced
this issue
Jan 25, 2019
…ely (#7145) ### Problem Resolves #6935. ### Solution - Extract some logic around chrooting from `JUnitRun` into `PartitionedTestRunnerTaskMixin`. - Make `GoTest` mix in `PartitionedTestRunnerTaskMixin` and implement all of the `@abstractmethod`s (everything worked first try, which makes me very suspicious as well as grateful). - Add an integration test for `go test`ing dependent targets. ### Result `./pants test.go` now has some funky features like `--chroot` or `--no-fast`, and tests dependent targets by default instead of requiring this to be done manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, test running for golang is not transitive, and this means that https://www.pantsbuild.org/orgs.html#continuous-integration will not actually result in all targets below your roots being tested.
In a local environment, it would be sufficient to implement and use
--no-fast,--chroot, and v1 Task invalidation: then each run would skip testing portions of the graph that had not changed since the previous run.In a distributed environment, it is also necessary to actually write to the v1 Task cache (likely by setting
Task.cache_target_dirs = True), so that parallel runners can reuse one-another's work.--no-fastand--chrootwould be identical to their descriptions in the junit and pytest runners.The text was updated successfully, but these errors were encountered: