make GoTest subclass PartitionedTestRunnerTaskMixin to test transitively #7145
Conversation
| shutil.copy(src, dest) | ||
|
|
||
| @contextmanager | ||
| def _chroot(self, targets, workdir): |
There was a problem hiding this comment.
Since you're now calling this in a subclass, it should lose the underscore prefix. We reserve Python's faux-private convention for symbols used only in the same class/file. The idea being that you shouldn't have to look outside the files for uses when making changes.
There was a problem hiding this comment.
Ok -- that sounds like we should also lose the underscore on _spawn_and_wait() then?
There was a problem hiding this comment.
Did both in 5e9b63c!
There was a problem hiding this comment.
Thanks! I wouldn't have asked you to fix _spawn_and_wait, as that's a preexisting condition... But thanks for doing it anyway.
There was a problem hiding this comment.
Oh -- is it better to isolate this change to _chroot then (just as a matter of what to do in these cases)? I'm fine with that!
…ransitively (pantsbuild#7145)" This reverts commit 7555976.
…7326) ### Problem Resolves #7188. #7145 allowed go tests to test their transitive dependencies (necessary because go targets contain both sources and test files), but it was broken in a few ways, leading to the revert in #7212. ### Solution - Return an iterable (`[]`) from `collect_files()` so the background cache insertion doesn't fail. - Make `PartitionedTestRunnerTaskMixin` no-op when there are no invalid targets instead of first calling `run_tests()`. - Turn `--build-and-test-flags` into a list of shlexed strings instead of a single string. ### Result The go testing from #7145 should have all its issues fixed!
Problem
Resolves #6935.
Solution
JUnitRunintoPartitionedTestRunnerTaskMixin.GoTestmix inPartitionedTestRunnerTaskMixinand implement all of the@abstractmethods (everything worked first try, which makes me very suspicious as well as grateful).go testing dependent targets.Result
./pants test.gonow has some funky features like--chrootor--no-fast, and tests dependent targets by default instead of requiring this to be done manually.