Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry locks missing hashes. #16112

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jul 9, 2022

This was due to this change on PyPI:
https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at ~/.cache/pypoetry on Linux and
~/Library/Caches/pypoetry on Mac.

Fixes #16111

[ci skip-rust]
[ci skip-build-wheels]

This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

[ci skip-rust]
[ci skip-build-wheels]
@@ -24,7 +24,7 @@ class PoetrySubsystem(PythonToolRequirementsBase):
options_scope = "poetry"
help = "Used to generate lockfiles for third-party Python dependencies."

default_version = "poetry==1.1.8"
default_version = "poetry==1.1.14"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, we have no lockfile for the Poetry tool! I will not tackle that in this hotfix PR though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poetry tool lockfile: #16117

@jsirois jsirois mentioned this pull request Jul 9, 2022
@jsirois jsirois added this to the 2.11.x milestone Jul 9, 2022
@benjyw
Copy link
Contributor

benjyw commented Jul 10, 2022

Will merge to unbreak things. Thanks for the detective work and the fix!

@benjyw benjyw merged commit b97936e into pantsbuild:main Jul 10, 2022
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
jsirois added a commit to jsirois/pants that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes pantsbuild#16111

(cherry picked from commit b97936e)

[ci skip-rust]
[ci skip-build-wheels]
@jsirois jsirois deleted the poetry/upgrade branch July 10, 2022 01:53
jsirois added a commit that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

(cherry picked from commit b97936e)
jsirois added a commit that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

(cherry picked from commit b97936e)
jsirois added a commit that referenced this pull request Jul 10, 2022
This was due to this change on PyPI:
  https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154

Which was fixed in Poetry yesterday here:
  python-poetry/poetry#5973

Unfortunately, the full fix requires blowing away the non-Pants
controlled Poetry cache at `~/.cache/pypoetry` on Linux and
`~/Library/Caches/pypoetry` on Mac.

Fixes #16111

(cherry picked from commit b97936e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pants poetry-based lockfiles fail to include hashes.
3 participants