Upgrade Pex to 2.1.95. #16110
Merged
Upgrade Pex to 2.1.95. #16110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This picks up several fixes that make PEX environments more robust to launch and use. It also picks up a new `--target-system` feature for universal resolves which is used in this change to limit our locks to Linux and Mac to pre-emptively avoid otherwise spurious lock errors. ALl Python lock files are re-generated with the new `--target-system` defaulting in place in order to drop a bunch of Windows-only dependencies and artifacts. See the changelog here: https://github.com/pantsbuild/pex/releases/tag/v2.1.95 [ci skip-rust] [ci skip-build-wheels]
|
If folks think regenerating all Python lock files was too aggressive, speak up. I don't have a strong opinion here and could restrict to just Pex and Lambdex as is normal with the Pex upgrades. |
|
The user reporting the issue |
jsirois
commented
Jul 9, 2022
| "url": "https://files.pythonhosted.org/packages/55/8d/74a75635f2c3c914ab5b3850112fd4b0c8039975ecb320e4449aa363ba54/atomicwrites-1.4.0.tar.gz" | ||
| } | ||
| ], | ||
| "project_name": "atomicwrites", |
There was a problem hiding this comment.
Hah! Apropos removal given recent events.
jsirois
commented
Jul 9, 2022
| @@ -176,6 +176,18 @@ async def generate_lockfile( | |||
| "--style=universal", | |||
| "--resolver-version", | |||
| "pip-2020-resolver", | |||
| # PEX files currently only run on Linux and Mac machines; so we hard code this | |||
There was a problem hiding this comment.
This is the one code change in all this noise version bump / ./build-support/bin/generate_all_lockfiles.sh --all noise.
[ci skip-rust] [ci skip-build-wheels]
|
The mypy-protobuf issue was: https://github.com/pantsbuild/pants/runs/7265712739?check_suite_focus=true#step:11:345 |
This was due to this change on PyPI: https://discuss.python.org/t/backwards-incompatible-change-to-pypi-json-api/17154 Which was fixed in Poetry yesterday here: python-poetry/poetry#5973 Unfortunately, the full fix requires blowing away the non-Pants controlled Poetry cache at `~/.cache/pypoetry` on Linux and `~/Library/Caches/pypoetry` on Mac. Fixes pantsbuild#16111 [ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
|
The Poetry issue is fixed over in #16112 which I've merged in. Interestingly, that requires no lockfile re-gen since Poetry appears to be the sole Python tool not using a lockfile! I'll not tackle that here. |
benjyw
approved these changes
Jul 10, 2022
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jul 10, 2022
This picks up several fixes that make PEX environments more robust to launch and use. It also picks up a new `--target-system` feature for universal resolves which is used in this change to limit our locks to Linux and Mac to pre-emptively avoid otherwise spurious lock errors. ALl Python lock files are re-generated with the new `--target-system` defaulting in place in order to drop a bunch of Windows-only dependencies and artifacts. See the changelog here: https://github.com/pantsbuild/pex/releases/tag/v2.1.95 (cherry picked from commit e7988a3) [ci skip-rust] [ci skip-build-wheels]
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jul 10, 2022
This picks up several fixes that make PEX environments more robust to launch and use. It also picks up a new `--target-system` feature for universal resolves which is used in this change to limit our locks to Linux and Mac to pre-emptively avoid otherwise spurious lock errors. ALl Python lock files are re-generated with the new `--target-system` defaulting in place in order to drop a bunch of Windows-only dependencies and artifacts. See the changelog here: https://github.com/pantsbuild/pex/releases/tag/v2.1.95 (cherry picked from commit e7988a3) [ci skip-rust] [ci skip-build-wheels]
|
Poetry tool lockfile: #16117 |
jsirois
added a commit
that referenced
this pull request
Jul 10, 2022
…-picks of #16110 & #15960) (#16116) Cherry-pick Pex upgrade and also cherry-pick Black upgrade to avoid pulling in a version of Click that breaks older Black during lock regeneration. --- Upgrade Pex to 2.1.95. (Cherry-pick of #16110) This picks up several fixes that make PEX environments more robust to launch and use. It also picks up a new `--target-system` feature for universal resolves which is used in this change to limit our locks to Linux and Mac to pre-emptively avoid otherwise spurious lock errors. ALl Python lock files are re-generated with the new `--target-system` defaulting in place in order to drop a bunch of Windows-only dependencies and artifacts. See the changelog here: https://github.com/pantsbuild/pex/releases/tag/v2.1.95 (cherry picked from commit e7988a3) --- Upgrade default version of black to 22.6.0 (Cherry-pick of #15960) (cherry picked from commit ec1cf20)
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Jul 11, 2022
This reverts commit e7988a3. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
that referenced
this pull request
Jul 11, 2022
This reverts #16110, as that changed caused wheel building to fail. To observe this failure, run ./build-support/bin/release.sh build-wheels Note that the revert was not clean due to #15951 also writing user_reqs.lock. So I regenerated that file to ensure validity, and manually verified that the failure above is fixed. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Jul 11, 2022
Note that the revert didn't apply cleanly, so I regenerated all the lockfiles. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Jul 11, 2022
Note that the revert didn't apply cleanly, so I regenerated all the lockfiles. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Jul 11, 2022
… (Cherry-picks of pantsbuild#16110 & pantsbuild#15960) (pantsbuild#16116)" This reverts commit 0987300. [ci skip-rust] [ci skip-build-wheels]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up several fixes that make PEX environments more robust to
launch and use. It also picks up a new
--target-systemfeature foruniversal resolves which is used in this change to limit our locks to
Linux and Mac to pre-emptively avoid otherwise spurious lock errors.
See the changelog here:
https://github.com/pantsbuild/pex/releases/tag/v2.1.95
[ci skip-rust]
[ci skip-build-wheels]