Revert "Upgrade Pex to 2.1.95 and default version of black to 22.6.0." #16128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
changed the title
jsirois
approved these changes
Jul 11, 2022
| group = "org.junit.platform" | ||
| artifact = "junit-platform-commons" | ||
| version = "1.7.2" | ||
| group = "org.apiguardian" |
There was a problem hiding this comment.
Hrm, I missed this in the main review. There is no --python-only flag to the re-gen script; so I had just reverted all JVM lockfile updates when I did the initial upgrade on main to 2.1.95. It's probably fine though / tests will cover the lock update as they always do or don't.
benjyw
force-pushed
the
cherrypick_16125_to_2.13.x
branch
from
8aeb941
to
c0c950c
Compare
… (Cherry-picks of pantsbuild#16110 & pantsbuild#15960) (pantsbuild#16116)" This reverts commit 0987300. [ci skip-rust] [ci skip-build-wheels]
benjyw
force-pushed
the
cherrypick_16125_to_2.13.x
branch
from
c0c950c
to
5f31569
Compare
benjyw
changed the title
|
Ended up doing this as a revert of the cherrypick of the upgrade, instead of a cherrypick of the revert in main, since the latter was very unclean and caused many tests to fail. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #16116, as that changed caused wheel building to fail.
To observe this failure, run ./build-support/bin/release.sh build-wheels
[ci skip-rust]
[ci skip-build-wheels]