Require Cargo.lock matches Cargo.toml in CI #19938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes
--lockedto the first interesting cargo invocations, to ensure that theCargo.lockfile is up to date withCargo.toml. Without this, if there's been changes toCargo.tomland the user hasn't run a cargo command locally afterwards, those invocation might change theCargo.lockfile (e.g. bump versions, add packages) and thus CI runs with an unexpected configuration, that's not recorded in the repo.(This came up in pantsbuild/scie-pants#290 and I thought to check other Rust repos that are tangentially related.)