Require Cargo.lock matches Cargo.toml in CI #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2023
kaos
approved these changes
Sep 26, 2023
huonw
added a commit
that referenced
this pull request
Sep 26, 2023
|
Validating that this does what we expect:
|
huonw
added a commit
to pantsbuild/pants
that referenced
this pull request
Sep 27, 2023
This passes `--locked` to the first interesting cargo invocations, to ensure that the `Cargo.lock` file is up to date with `Cargo.toml`. Without this, if there's been changes to `Cargo.toml` and the user hasn't run a cargo command locally afterwards, those invocation might change the `Cargo.lock` file (e.g. bump versions, add packages) and thus CI runs with an unexpected configuration, that's not recorded in the repo. (This came up in pantsbuild/scie-pants#290 and I thought to check other Rust repos that are tangentially related.)
huonw
added a commit
to a-scie/jump
that referenced
this pull request
Sep 27, 2023
This passes `--locked` to the first interesting cargo invocation, to ensure that the `Cargo.lock` file is up to date with `Cargo.toml`. Without this, if there's been changes to `Cargo.toml` and the user hasn't run a cargo command locally afterwards, the invocation might change the `Cargo.lock` file (e.g. bump versions, add packages) and thus CI runs with an unexpected configuration, that's not recorded in the repo. (This came up in pantsbuild/scie-pants#290 and I thought to check other Rust repos that are tangentially related.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks the mistake I made in #288 / #289, where I updated
Cargo.tomland forgot to run a command to updateCargo.lock.