-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all vcs versioning processes locally #21353
Conversation
I'm looking into writing a test for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and explaining the git logic.
Just confirming why we need to build the pex locally too: the pex built in the docker environment might not be compatible with the local environment, e.g. if the host is macOS, and the docker environment is linux. Is that right?
Also, does this need cherrypicking to 2.22.x? |
Correct - we have to build it where we run it. |
The previous change wasn't. I was treating this as more of a feature than a bug, but that is admittedly debatable. I could CP both of them - yeah, might as well. |
OK, this is the CP for the previous part: #21355 Will then auto-CP this one on top of it. |
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ❌ 2.22.xI was unable to cherry-pick this PR to 2.22.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. When you're done manually cherry-picking, please remove the Thanks again for your contributions! |
When using environments we must ensure we run VCS-related processes in the local environment and not the inherited one, as a docker environment will not have access to Git state. In pantsbuild#21188 we made setuptools_scm itself run locally, but this was not sufficient: this change makes sure we also run the pex building and git binary discovery in the local environment. Fixes pantsbuild#21178
When using environments we must ensure we run VCS-related processes in the local environment and not the inherited one, as a docker environment will not have access to Git state. In #21188 we made setuptools_scm itself run locally, but this was not sufficient: this change makes sure we also run the pex building and git binary discovery in the local environment. Fixes #21178
When using environments we must ensure we run VCS-related
processes in the local environment and not the inherited one,
as a docker environment will not have access to Git state.
In #21188 we made setuptools_scm itself run locally,
but this was not sufficient: this change makes sure we
also run the pex building and git binary discovery
in the local environment.
Fixes #21178