Revert "make GoTest subclass PartitionedTestRunnerTaskMixin to test transitively" #7212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransitively (pantsbuild#7145)" This reverts commit 7555976.
cosmicexplorer
approved these changes
Feb 4, 2019
cosmicexplorer
added a commit
to cosmicexplorer/pants
that referenced
this pull request
Mar 7, 2019
…o test transitively" (pantsbuild#7212)" This reverts commit b8999e1.
cosmicexplorer
added a commit
to cosmicexplorer/pants
that referenced
this pull request
Mar 24, 2019
…o test transitively" (pantsbuild#7212)" This reverts commit b8999e1.
cosmicexplorer
added a commit
that referenced
this pull request
Mar 31, 2019
…7326) ### Problem Resolves #7188. #7145 allowed go tests to test their transitive dependencies (necessary because go targets contain both sources and test files), but it was broken in a few ways, leading to the revert in #7212. ### Solution - Return an iterable (`[]`) from `collect_files()` so the background cache insertion doesn't fail. - Make `PartitionedTestRunnerTaskMixin` no-op when there are no invalid targets instead of first calling `run_tests()`. - Turn `--build-and-test-flags` into a list of shlexed strings instead of a single string. ### Result The go testing from #7145 should have all its issues fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7188.