chore(reth-network-p2p) support no_std #10047
Conversation
…us error variants
| impl From<RequestError> for DownloadError { | ||
| fn from(error: RequestError) -> Self { | ||
| Self::RequestError(error) | ||
| } | ||
| } | ||
|
|
||
| impl From<ProviderError> for DownloadError { | ||
| fn from(error: ProviderError) -> Self { | ||
| Self::Provider(error) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
same here as other pr, these don't have to be done manually, use https://jeltef.github.io/derive_more/derive_more/from.html
There was a problem hiding this comment.
Thanks for the review, this will make it much less verbose!
There was a problem hiding this comment.
exactly! and the great thing in turn with decreased verbosity, is that it's way easier to read the code that implements the functionality that sets this program apart from others
|
I originally opened this PR to stack on top of #10011 because some changes I made caused this crate to error. However, I was able to get that fixed over there without causing issues here so I'm going to close this PR. I may eventually have to come back here but for now I'm slightly out of scope so I"ll close this for now. |
Towards #9478
Stacks on top of #10011