-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reth-evm-ethereum): no_std test compilation errors #10602
base: main
Are you sure you want to change the base?
fix(reth-evm-ethereum): no_std test compilation errors #10602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a step in the right direction, and we will need this. This doesn't fully fix the compilation for no_std
, because the crate still depends on c-kzg
.
@@ -321,7 +321,7 @@ reth-ethereum-forks = { path = "crates/ethereum-forks" } | |||
reth-ethereum-payload-builder = { path = "crates/ethereum/payload" } | |||
reth-etl = { path = "crates/etl" } | |||
reth-evm = { path = "crates/evm" } | |||
reth-evm-ethereum = { path = "crates/ethereum/evm" } | |||
reth-evm-ethereum = { path = "crates/ethereum/evm", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that, we don't enable the std
feature anywhere in the project. @mattsse we should propagate this change to all crates that use reth-evm-ethereum
as a dependency, so they enable the std
feature of it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following dependencies in reth-evm-ethereum
have c-kzg
as default features:
reth-primitives
reth-revm
As far as I can tell, it seems that these are the main culprits; although, the rabbit hole may go deeper. Going off of #9430, would the move be to go from c-kzg
-> kzg-rs
in the reth-primitives
and reth-revm
?
Thank you for the review. I'm happy to wait to see what @mattsse says in regards to setting I wasn't exactly aiming to progress #10088 in this PR but I'm happy to make it the focus. I was mostly aiming in this PR to just get the failing tests to pass when running it with the In regards to
to run successfully? |
Towards #10088
In
reth-evm-ethereum
The tests fail when running:
cargo t -p reth-evm-ethereum --no-default-features
These changes fix the compilation issues