feat: partial wasm32-wasi compilation #9430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add std feature to network-peers get every crate to compile Wasm cleanup cleanup diff
jtguibas
force-pushed
the
john/zkvm-compilation
branch
from
8abc23a
to
0983b37
Compare
jtguibas
commented
Jul 10, 2024
| reth-trie-common = { path = "crates/trie/common" } | ||
| reth-trie-parallel = { path = "crates/trie/parallel" } | ||
|
|
||
| # revm | ||
| revm = { version = "11.0.0", features = [ |
There was a problem hiding this comment.
TODO: Update once bluealloy/revm#1601 merged into revm and revm-inspectors is also updated.
mattsse
requested changes
Jul 11, 2024
There was a problem hiding this comment.
could you submit this separately?
| @@ -16,6 +17,11 @@ pub(crate) fn default_page_size() -> usize { | |||
| os_page_size.clamp(min_page_size, libmdbx_max_page_size) | |||
| } | |||
|
|
|||
| #[cfg(not(feature = "page_size"))] | |||
| pub(crate) fn default_page_size() -> usize { | |||
| 0 | |||
There was a problem hiding this comment.
this is a bit dangerous
this is used as an option, so I think we want to make the function that is used to configure the page size return an option instead
reth/crates/storage/libmdbx-rs/src/environment.rs
Lines 632 to 637 in fc4c037
This was referenced Aug 1, 2024
|
Superseded by #10088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to set a foundation for supporting wasm32-wasi compilation of reth crates.
The currently supported crates are: reth-codecs, reth-consensus, reth-db, reth-db-api, reth-ethereum-forks, reth-evm, reth-evm-ethereum, reth-network-peers, reth-primitives, reth-primitives-traits, and reth-revm with no default features but std. Overtime, we can add support for more crates as needed.
Merging this PR succesfully requires having updated releases of
revmandrevm-inspectorfollowing the merge of this PR: bluealloy/revm#1601 due to the usage ofkzg-rsinstead ofc-kzgto get compilation to work successfully.