feat: add directory paths to Snapshotter and SnapshotProvider
#5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
shekhirin
reviewed
Nov 9, 2023
| range.end(), | ||
| ) | ||
| .into() | ||
| // ATTENTION: if changing the name format, be sure to reflect those changes in |
There was a problem hiding this comment.
can we add a test to check that the result of filename_with_configuration can be parsed by parse_filename?
Comment on lines
84
to
+91
| pub fn with_snapshots( | ||
| mut self, | ||
| snapshots_path: PathBuf, | ||
| highest_snapshot_tracker: watch::Receiver<Option<HighestSnapshots>>, | ||
| ) -> Self { | ||
| self.snapshot_provider = Some(Arc::new( | ||
| SnapshotProvider::default().with_highest_tracker(Some(highest_snapshot_tracker)), | ||
| SnapshotProvider::new(snapshots_path) | ||
| .with_highest_tracker(Some(highest_snapshot_tracker)), |
There was a problem hiding this comment.
I think these arguments became too verbose, can we just pass a Arc<SnapshotProvider> as an argument?
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
mattsse
approved these changes
Nov 14, 2023
Comment on lines
+88
to
+90
| snapshots_path: PathBuf, | ||
| chain_spec: Arc<ChainSpec>, | ||
| block_interval: u64, |
There was a problem hiding this comment.
nit:
I'd like to move snapshots_path + block_interval to a new SnapshotterConfig struct
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR into #5249
As title suggests.
Additionally:
strum::EnumStringfor some primitive types.update_highest_snapshots_trackerwill look into the directory and find the highest block number for each segment type.