feat: Snapshotter triggers segment snapshots
#5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
joshieDo
changed the title
Snapshotter triggers segment snapshots
mattsse
requested changes
Nov 6, 2023
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
mattsse
approved these changes
Nov 13, 2023
| &self, | ||
| block_range: Option<RangeInclusive<BlockNumber>>, | ||
| ) -> RethResult<()> { | ||
| if let Some(block_range) = block_range { |
There was a problem hiding this comment.
can use let Some else return here
shekhirin
approved these changes
Nov 13, 2023
rkrasiuk
approved these changes
Nov 13, 2023
mattsse
approved these changes
Nov 13, 2023
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR into #5283
Snapshotter] logic:run_segmentdatadir/snapshots/temp, and moved todatadir/snapshotsonce finished. This is to handle abrupt terminations of the node. This temp directory is cleaned up whenever the node is started.