Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): k256 crate fallback for secp256k1 module #9989

Merged
merged 18 commits into from
Aug 2, 2024
Merged

feat(primitives): k256 crate fallback for secp256k1 module #9989

merged 18 commits into from
Aug 2, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 1, 2024 •
edited
Loading

Towards #9478 for reth-primitives crate, inspired by #9430

The k256 implementation is cross-tested against secp256k1.

@shekhirin shekhirin added the C-enhancement New feature or request label Aug 1, 2024
@shekhirin shekhirin marked this pull request as ready for review August 1, 2024 15:33
@shekhirin shekhirin force-pushed the alexey/transaction-util-k256 branch from 9353f8d to 6e1614f Compare August 1, 2024 16:22
@shekhirin shekhirin requested a review from mattsse August 1, 2024 16:38
mattsse
mattsse requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs double check on c-kzg because this obfuscates revm features even more

reth/crates/primitives/Cargo.toml

Line 103 in 0fe93a8

c-kzg = ["dep:c-kzg", "revm-primitives/c-kzg", "dep:tempfile", "alloy-eips/kzg", "dep:thiserror-no-std"]

I think this will still get pulled in because we enable c-kzg for primitives somewhere else but still we need to do a proper workspace feature review

Cargo.toml Outdated Show resolved Hide resolved
crates/primitives/Cargo.toml Outdated Show resolved Hide resolved
crates/primitives/Cargo.toml Show resolved Hide resolved
crates/primitives/src/transaction/util.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@shekhirin shekhirin changed the title feat(primitives): k256 feature for secp256k1 module feat(primitives): k256 crate fallback for secp256k1 module Aug 1, 2024
@mattsse
Copy link
Collaborator

mattsse commented Aug 1, 2024

looks like some rpc code needs changes

@shekhirin shekhirin requested a review from emhane as a code owner August 2, 2024 07:29
mattsse
mattsse approved these changes Aug 2, 2024
View reviewed changes
crates/ethereum/evm/Cargo.toml Outdated Show resolved Hide resolved
@shekhirin shekhirin added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit d7f9a25 Aug 2, 2024
34 checks passed
@shekhirin shekhirin deleted the alexey/transaction-util-k256 branch August 2, 2024 13:07
@shekhirin shekhirin mentioned this pull request Aug 5, 2024
Open
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@shekhirin @martinezjorge
feat(primitives): k256 crate fallback for secp256k1 module (parad…
f313487 
…igmxyz#9989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse