prevent namespace conflicts #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change paragonie/easy-ecc will not be installed at the same time as mdanter/ecc to prevent conflicts with two packages providing the same namespaces.
|
Thanks, that's a good idea. |
derrabus
reviewed
Apr 25, 2024
Comment on lines
+32
to
+34
| "replace": { | ||
| "mdanter/ecc": "*" | ||
| }, |
There was a problem hiding this comment.
Is the * a good idea? It basically means that this package acts as a drop-in replacement for any version of mdanter/ecc which is certainly not the case.
This should be either conflict, meaning that this package and mdanter/ecc must not be installed at the same time, or we should pin the last release of the mdanter/ecc package here.
There was a problem hiding this comment.
What precisely is the scenario you are worried about?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change paragonie/easy-ecc will not be installed at the same time as mdanter/ecc to prevent conflicts with two packages providing the same namespaces.