Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent namespace conflicts #7

Merged
merged 1 commit into from
Apr 24, 2024
Merged

prevent namespace conflicts #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"role": "Previous Maintainer"
}
],
"replace": {
"mdanter/ecc": "*"
},
Comment on lines +32 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the * a good idea? It basically means that this package acts as a drop-in replacement for any version of mdanter/ecc which is certainly not the case.

This should be either conflict, meaning that this package and mdanter/ecc must not be installed at the same time, or we should pin the last release of the mdanter/ecc package here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What precisely is the scenario you are worried about?

"require": {
"php": "^7.1||^8.0",
"paragonie/sodium_compat": "^1|^2",
Expand Down
Loading