Bump bindgen for version 0.2.x of crate #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
added
the
code health
A new script is added to aid the regeneration of bindings whenever the bindgen version is changed, along with the bindings produced with bindgen v0.59.2. Signed-off-by: Ionut Mihalcea <[email protected]>
|
I'll port this to the |
wiktor-k
approved these changes
Feb 8, 2022
Signed-off-by: Ionut Mihalcea <[email protected]>
Update the script to make it shell-compliant. Update the MacOS Darwin bindings, and change bindings OS name from `unknown` to `apple`. Add this target to the list supported by the script. Update the `build.rs` file to use correct `bindgen` methods. Co-authored-by: Ionut Mihalcea <[email protected]> Co-authored-by: Anton Antonov <[email protected]> Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
bump-bindgen
branch
from
6262d1c
to
71b7b7c
Compare
|
I've updated the script to include the MacOS bindings as well, for some reason we had them down as |
Signed-off-by: Ionut Mihalcea <[email protected]>
Signed-off-by: Ionut Mihalcea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a separate branch for the
0.2.xversions of the crate, with the hope of using that for Parsec until we can update to0.3.0. A new release is needed on our side specifically for an update of thebindgendependency, which this PR addresses. However, I plan to also update the committed bindings, hence this PR being a draft. This plan includes a bash script for regenerating those bindings when needed.cc. @vkkoskie