-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for regenerating bindings #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool!! Will make so easy to add new bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good and nice! 👍 (I do miss the LF at the end of regenerate_bindings.sh
but it's a minor thing).
Signed-off-by: Ionut Mihalcea <[email protected]>
Signed-off-by: Ionut Mihalcea <[email protected]>
059882c
to
5920e16
Compare
Fixed!
I need to have a look at adding the same for the other FFI crates. |
Btw I ran the script through shellcheck and got the following:
I'm not a shell expert by any means so you'd have to decide if these lints are something to listen to but I wanted to provide yet another angle :) |
Signed-off-by: Ionut Mihalcea <[email protected]>
Ok, fixed those problems flagged by shellcheck. |
This builds on #82 which did the same thing for the
0.2.x
version of the crates.