Really no sourcemaps #4528
Merged
Really no sourcemaps #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
requested review from
devongovett,
wbinnssmith,
DeMoorJasper and
padmaia
|
mischnic
force-pushed
the
really-no-sourcemaps
branch
from
11d8311
to
9e98b14
Compare
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
mischnic
force-pushed
the
really-no-sourcemaps
branch
from
9e98b14
to
960879f
Compare
mischnic
force-pushed
the
really-no-sourcemaps
branch
2 times, most recently
from
1e9bdf6
to
8576c40
Compare
mischnic
force-pushed
the
really-no-sourcemaps
branch
5 times, most recently
from
7f80a0a
to
02c5656
Compare
mischnic
force-pushed
the
really-no-sourcemaps
branch
from
02c5656
to
c99a557
Compare
devongovett
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Closes #4390
Previously, we relied on plugins to not return sourcemaps if
target.sourceMapis false.But the non-hoisting JSPackager without running TerserOptimizer afterwards would still emit a sourcemap and therefore write a sourcemap file to dist despite of
--no-source-mapsQuestion
Sourcemaps can be specified per target, but they are only accessible onPluginOptions(a boolean from the cli flag) and onTarget(the actual settings object). So it would make sense to remove it from thePluginOptionsand put them onTargetonly (and normalizing the value in the target resolver), but then transformers wouldn't know if sourcemaps are enabled.