Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write sourcemaps for the serve mode's default target again #4569

Merged
merged 3 commits into from
May 5, 2020

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented May 5, 2020

↪️ Pull Request

Regression from #4528 found by @wbinnssmith

@height
Copy link

height bot commented May 5, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented May 5, 2020

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 5.71s -519.00ms 🚀
Cached 2.24s +28.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 292.00ms +60.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 291.00ms +59.00ms ⚠️
dist/legacy/kitchen-sink.679578a5.js 1.16kb +0.00b 1.46s -115.00ms 🚀
dist/modern/kitchen-sink.90de237b.js 1.16kb +0.00b 1.46s -116.00ms 🚀
dist/legacy/index.html 709.00b +0.00b 673.00ms +63.00ms ⚠️
dist/modern/index.html 709.00b +0.00b 670.00ms +62.00ms ⚠️
dist/legacy/styles.afb8e31a.css 78.00b +0.00b 1.30s -276.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 287.00ms +38.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 288.00ms +39.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 8.79s +170.00ms
Cached 2.25s +70.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/main/index.js 66.80kb +0.00b 258.00ms +54.00ms ⚠️
dist/module/index.js 37.47kb +0.00b 256.00ms +52.00ms ⚠️

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js x4 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

@wbinnssmith wbinnssmith merged commit 3c1c7db into v2 May 5, 2020
@mischnic mischnic deleted the serve-sourcemaps branch May 5, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants