Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add warp_sync_params #1909

Merged

Conversation

samelamin
Copy link
Contributor

add warp sync params to enable parachain warp sync

polkadot companion: paritytech/polkadot#6334
substrate companion: paritytech/substrate#12761

polkadot-parachain/src/service.rs Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
@samelamin samelamin requested a review from bkchr December 4, 2022 23:28
@samelamin samelamin force-pushed the add_warp_sync_params branch 2 times, most recently from ee9cd1f to 4cb1191 Compare December 5, 2022 09:49
@samelamin samelamin force-pushed the add_warp_sync_params branch 3 times, most recently from f1a09b4 to 76665f0 Compare December 13, 2022 11:50
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code still needs to change quite a bit here in Cumulus.

Please work together with @michalkucharczyk and @skunert to add a zombienet test for warp syncing. @michalkucharczyk has already done this in Substrate and can give you pointers and tips on how to do this for Cumulus.

polkadot-parachain/src/service.rs Outdated Show resolved Hide resolved
polkadot-parachain/src/service.rs Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
client/consensus/common/src/lib.rs Outdated Show resolved Hide resolved
client/network/Cargo.toml Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
client/network/src/lib.rs Outdated Show resolved Hide resolved
@samelamin samelamin force-pushed the add_warp_sync_params branch 4 times, most recently from 351783a to 481a6ff Compare December 19, 2022 21:07
@samelamin
Copy link
Contributor Author

@michalkucharczyk @skunert Please let me know if the zombie test I added makes sense

@samelamin samelamin force-pushed the add_warp_sync_params branch 2 times, most recently from c7ace8b to 4a02024 Compare December 20, 2022 20:12
@samelamin samelamin requested review from skunert and michalkucharczyk and removed request for skunert and michalkucharczyk December 20, 2022 20:23
@samelamin samelamin force-pushed the add_warp_sync_params branch 2 times, most recently from aa3aa6e to 39a2878 Compare December 20, 2022 20:35
@skunert
Copy link
Contributor

skunert commented Feb 8, 2023

FYI This PR is currently diener patched to use its companions repos for CI. This wiill be reverted before merge.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: "Check reviews" status is not passing for paritytech/polkadot#6334

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Github API says #1909 is not mergeable

@bkchr
Copy link
Member

bkchr commented Feb 14, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 1faed8b into paritytech:master Feb 14, 2023
ordian added a commit that referenced this pull request Feb 27, 2023
* master: (35 commits)
  add turboflakes system-chains bootnodes (#2223)
  Companion for #13349 (#2217)
  bump `zombienet` version to v1.3.35 (#2226)
  [ci] Return benchmark to bm machines (#2225)
  Collectives chain xcm filter (#2222)
  Add metaspan.io parachain boot nodes (#2218)
  Companion for #13390 (#2189)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219)
  Benchmarks script improvements (#2214)
  `BlockId` removal: refactor of runtime API (#2190)
  Rename .feature extension to .zndsl (#2215)
  Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213)
  WIP: Fix templates (#2204)
  Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201)
  Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161)
  Bump clap from 4.1.4 to 4.1.6 (#2193)
  Bump toml from 0.6.0 to 0.7.2 (#2170)
  companion for paritytech/polkadot#6161 (#2151)
  Bump serde_json from 1.0.92 to 1.0.93 (#2175)
  add warp_sync_params (#1909)
  ...
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-39/2277/1

AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 22, 2023
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 23, 2023
* Remove `account`

* Update and companions

* Companion of paritytech/cumulus#2164

* Companion of paritytech/substrate#13159

* Companion of paritytech/cumulus#1909

* Fmt

* Companion of paritytech/polkadot#6744

* Companion of paritytech/cumulus#2245

* Companion of paritytech/substrate#12828

* Companion of paritytech/cumulus#2287

* Companion of paritytech/substrate#13592

* Companion of paritytech/cumulus#2308

* Companion of paritytech/substrate#13410

* Companion of paritytech/substrate#13305

* Companion of polkadot-evm/frontier#1050

* TODO weight

* TODO weight

* Companion of polkadot-evm/frontier#1040

Signed-off-by: Xavier Lau <[email protected]>

* Remove unused dep

* Try fix dev node paritytech/substrate#12828

* Fix the frontier part (#1154)

* Fix dev node

* Fmt

* Bump moonbeam

* Bump moonbeam

* Remove unnecessary clone

* Fix tests

---------

Signed-off-by: Xavier Lau <[email protected]>
Co-authored-by: Guantong <[email protected]>
Co-authored-by: bear <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants