Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Executed event #1040

Merged

Conversation

boundless-forest
Copy link
Collaborator

Close #1036

@boundless-forest boundless-forest changed the title Extend the Executed event Extend the Executed event Apr 14, 2023
Copy link
Contributor

@tgmichel tgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a tests for this?

frame/ethereum/src/lib.rs Outdated Show resolved Hide resolved
@boundless-forest
Copy link
Collaborator Author

can you please add a tests for this?

Done.

@sorpaas sorpaas merged commit 8914332 into polkadot-evm:master Apr 18, 2023
@boundless-forest boundless-forest deleted the bear-extend-execute-event branch April 18, 2023 12:24
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 22, 2023
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 23, 2023
* Remove `account`

* Update and companions

* Companion of paritytech/cumulus#2164

* Companion of paritytech/substrate#13159

* Companion of paritytech/cumulus#1909

* Fmt

* Companion of paritytech/polkadot#6744

* Companion of paritytech/cumulus#2245

* Companion of paritytech/substrate#12828

* Companion of paritytech/cumulus#2287

* Companion of paritytech/substrate#13592

* Companion of paritytech/cumulus#2308

* Companion of paritytech/substrate#13410

* Companion of paritytech/substrate#13305

* Companion of polkadot-evm/frontier#1050

* TODO weight

* TODO weight

* Companion of polkadot-evm/frontier#1040

Signed-off-by: Xavier Lau <[email protected]>

* Remove unused dep

* Try fix dev node paritytech/substrate#12828

* Fix the frontier part (#1154)

* Fix dev node

* Fmt

* Bump moonbeam

* Bump moonbeam

* Remove unnecessary clone

* Fix tests

---------

Signed-off-by: Xavier Lau <[email protected]>
Co-authored-by: Guantong <[email protected]>
Co-authored-by: bear <[email protected]>
ashutoshvarma pushed a commit to AstarNetwork/frontier that referenced this pull request May 29, 2023
* Extend the event

* Code clean

* Update comment

* Fix tests

* Add event extra_bytes tests

* Asign `data.len()` to a variable

* Fix review
ashutoshvarma pushed a commit to AstarNetwork/frontier that referenced this pull request Jun 8, 2023
* Extend the event

* Code clean

* Update comment

* Fix tests

* Add event extra_bytes tests

* Asign `data.len()` to a variable

* Fix review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose detail revert message in event
3 participants