Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second iteration of weights v1.5 #1613

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Second iteration of weights v1.5 #1613

merged 1 commit into from
Oct 21, 2022

Conversation

svyatonik
Copy link
Contributor

What has been done here:

  • replaced Weight::from_ref_time(0) with Weight::zero() where I'm sure we don't need non-zero value of the second component;
  • replaced min_by + ref_time() with Weight::min where appropriate;
  • replaced ref_time() == 0 with Weight::is_zer() call where appropriate;
  • replaced w1.ref_time() <comparison-op> w2.ref_time with all_lte/all_gte/... calls where appropriate;
  • added WeightExtraOps trait for the min_components_checked_div fn that is missing from the Weight struct. We need it to compute number of messages that are fit into the delivery transaction.

Next iteration will be after v2 weights will become available - we'll need to deal with refund, weight formulae, benchmarks, ...

@svyatonik svyatonik added the dependencies Pull requests that update a dependency file label Oct 21, 2022
@svyatonik svyatonik merged commit d9a3345 into master Oct 21, 2022
@svyatonik svyatonik deleted the weighs-v1-5-iteration-2 branch October 21, 2022 10:43
jiguantong added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Oct 27, 2022
jiguantong added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Nov 17, 2022
hackfisher pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Nov 21, 2022
* update substrate dep master > v0.9.30

* Companion for paritytech/parity-bridges-common#1589

* Companion for paritytech/parity-bridges-common#1593

* Companion for paritytech/parity-bridges-common#1478

* Companion for paritytech/parity-bridges-common#1596

* Companion for paritytech/parity-bridges-common#1600

* Companion for paritytech/parity-bridges-common#1603

* Companion for paritytech/parity-bridges-common#1604

* Companion for paritytech/parity-bridges-common#1597 part.1

* Companion for paritytech/parity-bridges-common#1597 part.2 update weights

* Companion for paritytech/parity-bridges-common#1597 part.3

* Companion for paritytech/parity-bridges-common#1597 part.4 fix compile

* clear unused imports

* Companion for paritytech/parity-bridges-common#1613 part.1 undone

* fix tests
jiguantong added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Nov 21, 2022
* update substrate dep master > v0.9.30

* Companion for paritytech/parity-bridges-common#1589

* Companion for paritytech/parity-bridges-common#1593

* Companion for paritytech/parity-bridges-common#1478

* Companion for paritytech/parity-bridges-common#1596

* Companion for paritytech/parity-bridges-common#1600

* Companion for paritytech/parity-bridges-common#1603

* Companion for paritytech/parity-bridges-common#1604

* Companion for paritytech/parity-bridges-common#1597 part.1

* Companion for paritytech/parity-bridges-common#1597 part.2 update weights

* Companion for paritytech/parity-bridges-common#1597 part.3

* Companion for paritytech/parity-bridges-common#1597 part.4 fix compile

* clear unused imports

* Companion for paritytech/parity-bridges-common#1613 part.1 undone

* fix tests
boundless-forest added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 4, 2023
* Prepare polkadot v0.9.30 for darwinia-2.0 (#226)

* update substrate dep master > v0.9.30

* Companion for paritytech/parity-bridges-common#1589

* Companion for paritytech/parity-bridges-common#1593

* Companion for paritytech/parity-bridges-common#1478

* Companion for paritytech/parity-bridges-common#1596

* Companion for paritytech/parity-bridges-common#1600

* Companion for paritytech/parity-bridges-common#1603

* Companion for paritytech/parity-bridges-common#1604

* Companion for paritytech/parity-bridges-common#1597 part.1

* Companion for paritytech/parity-bridges-common#1597 part.2 update weights

* Companion for paritytech/parity-bridges-common#1597 part.3

* Companion for paritytech/parity-bridges-common#1597 part.4 fix compile

* clear unused imports

* Companion for paritytech/parity-bridges-common#1613 part.1 undone

* fix tests

* 0930 > master

* try fix CI

* fix CI

* Use `H160` as `AccountId` (#230)

* Use H160 in darwinia-core

* H256 > H160

* update moonbeam account

* Fix tests

* remove debug println

* Fix review

* Fix review

* Compatible `derive_account_id` (#234)

* new derive_account_id

* adjust

* add test

* Keep compatible of the derive way

* Fix test

* Update converter

* Self review

Co-authored-by: Aki Wu <[email protected]>

* update cargo

* master -> polkadot-v0.9.30

Co-authored-by: bear <[email protected]>
Co-authored-by: Aki Wu <[email protected]>
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 5, 2023
boundless-forest pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 12, 2023
* Anchor polkadot-v0.9.32

* fix parity-util-mem conflict

* Anchor polkadot-v0.9.33

* Companion for paritytech/parity-bridges-common#1613

* Companion for paritytech/parity-bridges-common#1616

* Companion for paritytech/parity-bridges-common#1619

* Companion for paritytech/parity-bridges-common#1623

* Companion for paritytech/parity-bridges-common#1622

* Companion for paritytech/parity-bridges-common#1655

* Companion for paritytech/parity-bridges-common#1670

* Companion for paritytech/parity-bridges-common#1690

* Correct cargo

* Revert "Companion for paritytech/parity-bridges-common#1690"

This reverts commit 926b32d.

* Revert "Companion for paritytech/parity-bridges-common#1670"

This reverts commit b96b41c.

* Fix compile

* Revert "Companion for paritytech/parity-bridges-common#1622"

This reverts commit 4c5865d.

* Fix compile

* format

* Fix test

* Fix dispatch test

* Try fix compile with darwinia-2.0

* Revert "Try fix compile with darwinia-2.0"

This reverts commit c9dcd67.

* Update prepare branch

* Format

* Remove unused trait

* Remove unused import
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 17, 2023
* Anchor polkadot-v0.9.32

* fix parity-util-mem conflict

* Anchor polkadot-v0.9.33

* Companion for paritytech/parity-bridges-common#1613

* Companion for paritytech/parity-bridges-common#1616

* Companion for paritytech/parity-bridges-common#1619

* Companion for paritytech/parity-bridges-common#1623

* Companion for paritytech/parity-bridges-common#1622

* Companion for paritytech/parity-bridges-common#1655

* Companion for paritytech/parity-bridges-common#1670

* Companion for paritytech/parity-bridges-common#1690

* Correct cargo

* Revert "Companion for paritytech/parity-bridges-common#1690"

This reverts commit 926b32d.

* Revert "Companion for paritytech/parity-bridges-common#1670"

This reverts commit b96b41c.

* Fix compile

* Revert "Companion for paritytech/parity-bridges-common#1622"

This reverts commit 4c5865d.

* Fix compile

* format

* Fix test

* Fix dispatch test

* Try fix compile with darwinia-2.0

* Revert "Try fix compile with darwinia-2.0"

This reverts commit c9dcd67.

* Update prepare branch

* Format

* Remove unused trait

* Remove unused import
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 17, 2023
…238)

* Anchor polkadot-v0.9.32

* fix parity-util-mem conflict

* Anchor polkadot-v0.9.33

* Companion for paritytech/parity-bridges-common#1613

* Companion for paritytech/parity-bridges-common#1616

* Companion for paritytech/parity-bridges-common#1619

* Companion for paritytech/parity-bridges-common#1623

* Companion for paritytech/parity-bridges-common#1622

* Companion for paritytech/parity-bridges-common#1655

* Companion for paritytech/parity-bridges-common#1670

* Companion for paritytech/parity-bridges-common#1690

* Correct cargo

* Revert "Companion for paritytech/parity-bridges-common#1690"

This reverts commit 926b32d.

* Revert "Companion for paritytech/parity-bridges-common#1670"

This reverts commit b96b41c.

* Fix compile

* Revert "Companion for paritytech/parity-bridges-common#1622"

This reverts commit 4c5865d.

* Fix compile

* format

* Fix test

* Fix dispatch test

* Try fix compile with darwinia-2.0

* Revert "Try fix compile with darwinia-2.0"

This reverts commit c9dcd67.

* Update prepare branch

* Format

* Remove unused trait

* Remove unused import
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
* Companion for substrate#11983.

* cargo update -p sp-io

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* cargo update -p polkadot-runtime-common

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Revert "cargo update -p polkadot-runtime-common"

This reverts commit bdadad94c54836980a8dbafe3e6ecb33a94f3e17.

* Revert "cargo update -p sp-io"

This reverts commit f6b4ecc53f54982c9c8ec0d9368baad19063bda4.

* cargo update -p sp-io

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants