-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finality loop: get block justification and authorities change by consensus engine ID #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the check for authority changes more generic
svyatonik
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left couple of questions
svyatonik
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 5, 2023
boundless-forest
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 12, 2023
* Anchor polkadot-v0.9.32 * fix parity-util-mem conflict * Anchor polkadot-v0.9.33 * Companion for paritytech/parity-bridges-common#1613 * Companion for paritytech/parity-bridges-common#1616 * Companion for paritytech/parity-bridges-common#1619 * Companion for paritytech/parity-bridges-common#1623 * Companion for paritytech/parity-bridges-common#1622 * Companion for paritytech/parity-bridges-common#1655 * Companion for paritytech/parity-bridges-common#1670 * Companion for paritytech/parity-bridges-common#1690 * Correct cargo * Revert "Companion for paritytech/parity-bridges-common#1690" This reverts commit 926b32d. * Revert "Companion for paritytech/parity-bridges-common#1670" This reverts commit b96b41c. * Fix compile * Revert "Companion for paritytech/parity-bridges-common#1622" This reverts commit 4c5865d. * Fix compile * format * Fix test * Fix dispatch test * Try fix compile with darwinia-2.0 * Revert "Try fix compile with darwinia-2.0" This reverts commit c9dcd67. * Update prepare branch * Format * Remove unused trait * Remove unused import
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 17, 2023
* Anchor polkadot-v0.9.32 * fix parity-util-mem conflict * Anchor polkadot-v0.9.33 * Companion for paritytech/parity-bridges-common#1613 * Companion for paritytech/parity-bridges-common#1616 * Companion for paritytech/parity-bridges-common#1619 * Companion for paritytech/parity-bridges-common#1623 * Companion for paritytech/parity-bridges-common#1622 * Companion for paritytech/parity-bridges-common#1655 * Companion for paritytech/parity-bridges-common#1670 * Companion for paritytech/parity-bridges-common#1690 * Correct cargo * Revert "Companion for paritytech/parity-bridges-common#1690" This reverts commit 926b32d. * Revert "Companion for paritytech/parity-bridges-common#1670" This reverts commit b96b41c. * Fix compile * Revert "Companion for paritytech/parity-bridges-common#1622" This reverts commit 4c5865d. * Fix compile * format * Fix test * Fix dispatch test * Try fix compile with darwinia-2.0 * Revert "Try fix compile with darwinia-2.0" This reverts commit c9dcd67. * Update prepare branch * Format * Remove unused trait * Remove unused import
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 17, 2023
…238) * Anchor polkadot-v0.9.32 * fix parity-util-mem conflict * Anchor polkadot-v0.9.33 * Companion for paritytech/parity-bridges-common#1613 * Companion for paritytech/parity-bridges-common#1616 * Companion for paritytech/parity-bridges-common#1619 * Companion for paritytech/parity-bridges-common#1623 * Companion for paritytech/parity-bridges-common#1622 * Companion for paritytech/parity-bridges-common#1655 * Companion for paritytech/parity-bridges-common#1670 * Companion for paritytech/parity-bridges-common#1690 * Correct cargo * Revert "Companion for paritytech/parity-bridges-common#1690" This reverts commit 926b32d. * Revert "Companion for paritytech/parity-bridges-common#1670" This reverts commit b96b41c. * Fix compile * Revert "Companion for paritytech/parity-bridges-common#1622" This reverts commit 4c5865d. * Fix compile * format * Fix test * Fix dispatch test * Try fix compile with darwinia-2.0 * Revert "Try fix compile with darwinia-2.0" This reverts commit c9dcd67. * Update prepare branch * Format * Remove unused trait * Remove unused import
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…ensus engine ID (paritytech#1619) * SignedBlock: get justification by consensus engine id * Define ConsensusLogReader Making the check for authority changes more generic * cod review changes
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…ensus engine ID (paritytech#1619) * SignedBlock: get justification by consensus engine id * Define ConsensusLogReader Making the check for authority changes more generic * cod review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.