Skip to content

Commit

Permalink
Upgraded review-bot to version 2.0.1 (#1784)
Browse files Browse the repository at this point in the history
## [Updated review bot
version](677610b)

updated version to version `2.0.1` which contains
paritytech/review-bot#90, a fix for the team
members not being fetch in its totality.

## [Updated review-bot.yml minApprovals
convention](b144683)

Renamed `min_approvals` to `minApprovals`. A breaking change in
paritytech/review-bot#86 which was done to
standarize all the cases (so now everything is camelCase)
  • Loading branch information
Bullrich authored Oct 4, 2023
1 parent d80171e commit cd076d7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
23 changes: 11 additions & 12 deletions .github/review-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ rules:
- ^\.cargo/.*
exclude:
- ^./gitlab/pipeline/zombienet.*
min_approvals: 2
minApprovals: 2
type: basic
teams:
- ci
Expand All @@ -27,7 +27,7 @@ rules:
exclude:
- ^polkadot/runtime\/(kusama|polkadot)\/src\/weights\/.+\.rs$
- ^substrate\/frame\/.+\.md$
min_approvals: 1
minApprovals: 1
allowedToSkipRule:
teams:
- core-devs
Expand All @@ -54,7 +54,7 @@ rules:
- ^\.gitlab/.*
- ^\.config/nextest.toml
- ^\.cargo/.*
min_approvals: 2
minApprovals: 2
type: basic
teams:
- core-devs
Expand All @@ -70,10 +70,10 @@ rules:
- ^cumulus/parachains/common/src/[^/]+\.rs$
type: and-distinct
reviewers:
- min_approvals: 1
- minApprovals: 1
teams:
- locks-review
- min_approvals: 1
- minApprovals: 1
teams:
- polkadot-review

Expand All @@ -83,7 +83,7 @@ rules:
condition:
include:
- ^bridges/.*
min_approvals: 1
minApprovals: 1
teams:
- bridges-core

Expand All @@ -95,10 +95,10 @@ rules:
- ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
type: "and"
reviewers:
- min_approvals: 2
- minApprovals: 2
teams:
- core-devs
- min_approvals: 1
- minApprovals: 1
teams:
- frame-coders

Expand All @@ -107,15 +107,14 @@ rules:
condition:
include:
- review-bot\.yml
min_approvals: 2
type: "and"
reviewers:
- min_approvals: 1
- minApprovals: 1
teams:
- opstooling
- min_approvals: 1
- minApprovals: 1
teams:
- locks-review
- min_approvals: 1
- minApprovals: 1
teams:
- ci
2 changes: 1 addition & 1 deletion .github/workflows/review-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
app_id: ${{ secrets.REVIEW_APP_ID }}
private_key: ${{ secrets.REVIEW_APP_KEY }}
- name: "Evaluates PR reviews and assigns reviewers"
uses: paritytech/review-bot@v1.1.0
uses: paritytech/review-bot@v2.0.1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
team-token: ${{ steps.team_token.outputs.token }}
Expand Down

0 comments on commit cd076d7

Please sign in to comment.