Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where only 30 members where shown #90

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Oct 3, 2023

Fixed a pagination issue where the system was only obtaining the first 30 membes of a team.

By adding the pagination method of Octokit we can obtain all of the results at once.

Updated project version to 2.0.1 to generate a new release.

This fixes #88

@Bullrich Bullrich requested a review from a team as a code owner October 3, 2023 14:38
@Bullrich Bullrich self-assigned this Oct 3, 2023
@Bullrich Bullrich changed the title Fixed not obtaining all team members Fixed bug where only 30 members where shown Oct 3, 2023
@Bullrich Bullrich enabled auto-merge (squash) October 3, 2023 17:13
@Bullrich Bullrich merged commit a2988bc into main Oct 3, 2023
11 checks passed
@Bullrich Bullrich deleted the pagination-fix branch October 3, 2023 17:14
Bullrich added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 3, 2023
updated version to version 2.0.1 which contains paritytech/review-bot#90, a fix for the team members not being in its totality.
Bullrich added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 4, 2023
## [Updated review bot
version](677610b)

updated version to version `2.0.1` which contains
paritytech/review-bot#90, a fix for the team
members not being fetch in its totality.

## [Updated review-bot.yml minApprovals
convention](b144683)

Renamed `min_approvals` to `minApprovals`. A breaking change in
paritytech/review-bot#86 which was done to
standarize all the cases (so now everything is camelCase)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get all the team members
2 participants