-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds BlockNumberProvider
in multisig, proxy and nft pallets
#5723
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as abstractions to add, excluding the possible need for a migration.
…polkadot-sdk into gupnik/block-number-provider
The metric through which you have chosen to migrate Nft pallet seems wrong btw -- this pallet is not priority as it is not on the relay chain. |
…ik/block-number-provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me,
Using different types make the change easier to check.
Step in #3268
This PR adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa.
This change is backwards compatible:
BlockNumberProvider
continues to use the system pallet's block numberHowever, we would need migrations if the deployed pallets are upgraded on an existing parachain, and the
BlockNumberProvider
uses the relay chain block number.