Adds BlockNumberProvider in alliance, collective and identity pallets
#6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Nov 5, 2024
| @@ -308,6 +308,9 @@ pub mod pallet { | |||
| /// The number of blocks a member must wait between giving a retirement notice and retiring. | |||
| /// Supposed to be greater than time required to `kick_member`. | |||
| type RetirementPeriod: Get<BlockNumberFor<Self>>; | |||
|
|
|||
| /// Provider for the block number. Normally this is the `frame_system` pallet. | |||
| type BlockNumberProvider: BlockNumberProvider<BlockNumber = BlockNumberFor<Self>>; | |||
There was a problem hiding this comment.
Same as some other PR. I think this is fixing the BlockNumber to be the system block number. But there is no need for this.
The block number could be the one of the relay chain, in which case it doesn't need to be = BlockNumberFor<Self>.
davidk-pt
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step in #3268
Similar to #5723, This PR adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa.
This change is backwards compatible:
BlockNumberProvidercontinues to use the system pallet's block numberHowever, we would need migrations if the deployed pallets are upgraded on an existing parachain, and the
BlockNumberProvideruses the relay chain block number.