Companion PR for #6846 #1568
Companion PR for #6846 #1568
Conversation
seunlanlege
added
the
A2-insubstantial
|
Honestly not sure what I'm doing wrong, but isn't CI supposed to automagically figure out that this a companion pr and adjust the branch accordingly? |
|
@seunlanlege #1549 not any more. |
|
I think you just ignore the CI failures. |
|
Yes! Thank you. Just ignore the failures and re-run the build when substrate has been merge (or just use bot merge and it should merge anyway) @seunlanlege copy-pasting what I said the other day:
|
…strate-test-runner
…strate-test-runner
|
Waiting for commit status. |
|
@sjeohp This should not happen IMO. This branch has already been tested in substrate with check-polkadot-companion-build. Now this build is running in polkadot but substrate has been merged. Everybody who is right now trying to make a branch on substrate with a companion branch are stuck because substrate and polkadot are out-of-sync for some time (the time of this build). Would it be possible to bypass the checks and make the merge happens immediately (in general, I'm not talking about this PR as it is the weekend anyway)? |
|
(I mean it is fine that the Cargo.lock is updated before merge but it shouldn't wait for the status to succeed) |
|
Checks failed; merge aborted. |
|
I waited this build to show the problem:
The build failed because the labels are not set properly. But we don't care because it really is a change in substrate where there are labels already. But now we have a permanent state where nobody can merge their PR on substrate until this issue is manually fixed by someone. This should not happen: if substrate succeeded, it should be merged right away, without additional check, without additional build time. |
cecton
added
B0-silent
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
@cecton It would mean granting processbot admin privileges I think, where currently it is only maintainer. |
* master: Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556)
…n-race-condition * master: Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563)
* master: overseer: fix build (#1596) Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
Companion PR for paritytech/substrate#6846