Allow using any polkadot client instead of enum Client #1575

cecton · 2020-08-12T16:26:49Z

Related to paritytech/cumulus#199

Forked at: e916423 Parent branch: origin/rococo-branch

collator/src/lib.rs

service/src/client.rs

Forked at: e916423 Parent branch: origin/rococo-branch

cecton · 2020-08-13T07:48:54Z

service/src/client.rs

+/// Yet Another ExecuteWithClient
+pub trait YaExecuteWithClient {
+	/// Execute the given something with the client.
+	fn execute_with<T: ExecuteWithClient>(&self, t: T) -> T::Output;
+}


I'm not sure how to call it... ClientExecutor? ClientExecutionContext? @bkchr

Forked at: e916423 Parent branch: origin/rococo-branch

bkchr · 2020-08-13T07:55:17Z

collator/src/lib.rs

 		spawner: SP,
 		network: impl Network + SyncOracle + Clone + 'static,
 	) -> Result<Self::ParachainContext, ()>
 		where
-			SP: SpawnNamed + Clone + Send + Sync + 'static;
+			SP: SpawnNamed + Clone + Send + Sync + 'static,
+			Backend: BackendT<Block>,


I was sooo happy that we got rid off it :P But yeah, this will also make some code easier in Cumulus 👍

I AM SO SORRY

bkchr · 2020-08-13T08:04:16Z

service/src/client.rs

@@ -118,6 +118,12 @@ pub trait ExecuteWithClient {
 			Client: AbstractClient<Block, Backend, Api = Api> + 'static;
 }

+/// Yet Another ExecuteWithClient
+pub trait YaExecuteWithClient {


Maybe ClientHandle?

With a much better documentation on what it does and why we need it? Something like:

/// A handle to a Polkadot client instance /// /// The Polkadot service supports multiple different runtimes, like /// Westend, Polkadot itself, etc. As each runtime has a specialized /// client, we need to hide them behind a trait. This is this trait. /// /// When wanting to work with the inner client, you need to use [`execute_with`](ClientHandle::execute_with). /// See [`ExecuteWithClient`] for more information.

omg I was not expecting that much 😆 🙏

Forked at: e916423 Parent branch: origin/rococo-branch

cecton · 2020-08-13T08:29:00Z

bot merge

ghost · 2020-08-13T08:29:05Z

Missing process info; check that the PR belongs to a project column.

cecton · 2020-08-13T08:30:18Z

bot merge

ghost · 2020-08-13T08:30:23Z

Waiting for commit status.

* WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * Apply suggestions from code review * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * CLEANUP Forked at: e916423 Parent branch: origin/rococo-branch * link in doc * doc

* master: Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)

…n-race-condition * master: Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563)

* master: overseer: fix build (#1596) Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)

* WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * Apply suggestions from code review * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * CLEANUP Forked at: e916423 Parent branch: origin/rococo-branch * link in doc * doc

paritytech-ci added the D2-breaksapi label Aug 12, 2020

cecton added 8 commits August 12, 2020 18:29

WIP

ac4e6c4

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

5527eaa

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

47f184e

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

f60375c

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

99bbf74

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

43512e8

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

ae7082c

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

fb78f0b

Forked at: e916423 Parent branch: origin/rococo-branch

cecton force-pushed the cecton-allow-using-any-polkadot-client branch from 14590ff to fb78f0b Compare August 12, 2020 16:29

cecton commented Aug 12, 2020

View reviewed changes

collator/src/lib.rs Outdated Show resolved Hide resolved

cecton commented Aug 12, 2020

View reviewed changes

service/src/client.rs Outdated Show resolved Hide resolved

cecton and others added 3 commits August 12, 2020 18:36

Apply suggestions from code review

846e23f

WIP

5caaaeb

Forked at: e916423 Parent branch: origin/rococo-branch

WIP

0070028

Forked at: e916423 Parent branch: origin/rococo-branch

cecton commented Aug 13, 2020

View reviewed changes

cecton marked this pull request as ready for review August 13, 2020 07:49

github-actions bot added the A0-please_review Pull request needs code review. label Aug 13, 2020

WIP

b66861c

Forked at: e916423 Parent branch: origin/rococo-branch

bkchr approved these changes Aug 13, 2020

View reviewed changes

cecton added 3 commits August 13, 2020 10:12

CLEANUP

96cdf51

Forked at: e916423 Parent branch: origin/rococo-branch

link in doc

5c4f5ca

doc

12cbf02

cecton added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 13, 2020

ghost merged commit 3b62357 into master Aug 13, 2020

ghost deleted the cecton-allow-using-any-polkadot-client branch August 13, 2020 08:40

cecton mentioned this pull request Sep 4, 2020

Backport: Make ValidationPool accepts execution mode to run custom command or in process validation (#1622) #1675

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow using any polkadot client instead of enum Client #1575

Allow using any polkadot client instead of enum Client #1575

cecton commented Aug 12, 2020

cecton Aug 13, 2020

bkchr Aug 13, 2020

cecton Aug 13, 2020

bkchr Aug 13, 2020

cecton Aug 13, 2020

cecton commented Aug 13, 2020

ghost commented Aug 13, 2020

cecton commented Aug 13, 2020

ghost commented Aug 13, 2020

Allow using any polkadot client instead of enum Client #1575

Allow using any polkadot client instead of enum Client #1575

Conversation

cecton commented Aug 12, 2020

cecton Aug 13, 2020

Choose a reason for hiding this comment

bkchr Aug 13, 2020

Choose a reason for hiding this comment

cecton Aug 13, 2020

Choose a reason for hiding this comment

bkchr Aug 13, 2020

Choose a reason for hiding this comment

cecton Aug 13, 2020

Choose a reason for hiding this comment

cecton commented Aug 13, 2020

ghost commented Aug 13, 2020

cecton commented Aug 13, 2020

ghost commented Aug 13, 2020