Find identity in accounts with sub-identity #107
Assignees
Labels
bug
Something isn't working
Comments
Bullrich
added a commit
that referenced
this issue
Jan 3, 2024
Added logic to search for a super identity in case that the user does not have an identity. If a super identity is found, this will be added to the array of address to fetch an identity from. This fixes #107
Bullrich
added a commit
that referenced
this issue
Jan 3, 2024
Added logic to search for a super identity in case that the user does not have an identity. If a super identity is found, this will be added to the array of address to fetch an identity from. This fixes #107 Updated version to `2.3.1` as this is a small patch.
bkchr
pushed a commit
to polkadot-fellows/runtimes
that referenced
this issue
Jan 4, 2024
Updated review bot to version 2.3.1 which contains the fix for paritytech/review-bot#107. When a fellow's identity is empty, it will search for a sub identity and try to extract the handle from such subidentity. I have also added @ggwpez's brilliant site to the readme so the fellow's can see their list of identities (as I don't have any up-to-date listing myself).
This was referenced Mar 15, 2024
fellowship-merge-bot bot
added a commit
to polkadot-fellows/runtimes
that referenced
this issue
Mar 18, 2024
This upgrade contains the change in paritytech/auto-merge-bot#25 which fixes the problem with unstable branches. ## The problem When the `/merge` command is triggered on a PR that still can't be merge, the bot enables auto-merge. **But**, when the command is run when the PR is ready to merge, the action will fail to enable auto-merge (this is expected). We evaluate the error message, and if it says that the PR is clean, it simply merges the PR. But, we did not handle `unstable` PRs. An unstable PR is a PR that _can be merged, but a **non required status check is failing**._ So, if a user invoked the `/merge` command on a PR that was ready to merge, but a not-required status check was failing, it would crash. This upgrade fixes this problem. ### Other upgrades #### `get-fellows-action` has been upgraded to `1.1.0` This new version contains: - paritytech/get-fellows-action#15 - Fixed a bug where candidates (`rank 0`) counted as fellows. - Now we filter anyone whose rank is below 1. - paritytech/get-fellows-action#16 - Fixes a problem where a fellow using a superidentity wouldn't appear. - This is a particular case that I discovered with @joepetrowski not appearing as a fellow. - This error was also encountered in review bot and fixed in paritytech/review-bot#107 - paritytech/get-fellows-action#11 - We upgraded the system to work with `papi` and with `smoldot`. - We are **bleeding edge** now! #### replaced token generation script for github's We replaced the action used to generate a token from a github app, originally `tibdex/github-app-token` for `actions/create-github-app-token` It is more safe to use an action that has been developed by github themselves than by an external party. --- - [x] Does not require a CHANGELOG entry --------- Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use
Identity::SuperOfto find user's who identity are in a sub account.Example code: chain.rs (for the site https://fellowship.tasty.limo/)
The text was updated successfully, but these errors were encountered: