Add kusama and polkadot SP constants #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadanda
commented
Dec 12, 2023
seadanda
changed the title
These should be imported from parachains_common directly, not through the runtimes.
bkontur
approved these changes
Dec 21, 2023
ggwpez
reviewed
Jan 3, 2024
ggwpez
reviewed
Jan 3, 2024
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
approved these changes
Jan 3, 2024
ascjones
approved these changes
Jan 3, 2024
joepetrowski
approved these changes
Jan 3, 2024
|
@Bullrich the bot is not picking up the approvals here. |
Has something changed in the identity pallet? Some users who had an account now are null. For example, when fetching @joepetrowski's account:
This used to work before and I haven't modified any of this code, so I first need to be aware of any changes so I can keep the code up to date. |
|
Seems that the problem is caused by subidentities. I have an issue for it: paritytech/review-bot#107 Will put it as top priority and start working on it right now 🦾 |
xlc
approved these changes
Jan 3, 2024
bkchr
approved these changes
Jan 4, 2024
Merged
ggwpez
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the Kusama and Polkadot constants for System Parachains into the control of the Fellowship.
Following up on paritytech/polkadot-sdk#2620 and paired with paritytech/polkadot-sdk#2666.
Types are still used from the
parachains-commoncrate, but constants are moved into a new cratesystem-parachains-constantsin this repo.The re-exports
pub use parachains_common as commonin both asset hubs and collectives have been removed. This is a breaking change for anybody using them in this way, but these should be directly imported fromparachains-common. This should be noted on the changelog.