Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect key events instead of event for Live Activity #136

Closed
wants to merge 2 commits into from
Closed

fix: Incorrect key events instead of event for Live Activity #136

wants to merge 2 commits into from

Conversation

kurtguenther
Copy link

Continuing from here.

This reverts this PR from @dplewis.
Additionally it adds dismissal-date as a field to APS + tests.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 5, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@kurtguenther kurtguenther changed the title Fixes #135: reverting events => event in APS for live activity. Adds dismissal-date to APS. Closes: #135 reverting events => event in APS for live activity. Adds dismissal-date to APS. Oct 5, 2023
@kurtguenther kurtguenther changed the title Closes: #135 reverting events => event in APS for live activity. Adds dismissal-date to APS. fix: Closes: #135 reverting events => event in APS for live activity. Adds dismissal-date to APS. Oct 5, 2023
@kurtguenther kurtguenther changed the title fix: Closes: #135 reverting events => event in APS for live activity. Adds dismissal-date to APS. fix: reverting events => event in APS for live activity. Adds dismissal-date to APS. #135 Oct 5, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: reverting events => event in APS for live activity. Adds dismissal-date to APS. #135 fix: Reverting events => event in APS for live activity. Adds dismissal-date to APS. #135 Oct 5, 2023
@mtrezza mtrezza changed the title fix: Reverting events => event in APS for live activity. Adds dismissal-date to APS. #135 feat: Add parameter dismissal-date; fix incorrect key events instead of event for Live Activity Oct 5, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 5, 2023 •
edited
Loading

This is 2 PRs (feature addition + bug fix) in 1. Could you please separate the dismissal date addition into a separate PR? Unless it's related to the bug fix of course.

@mtrezza mtrezza changed the title feat: Add parameter dismissal-date; fix incorrect key events instead of event for Live Activity fix: Incorrect key events instead of event for Live Activity Oct 5, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 19, 2023 •
edited
Loading

@kurtguenther Do you think you could move the feature addition into a separate PR, so we can get this bug fix merged? It also seems that the feature tests are not passing in the CI.

@mtrezza
Copy link
Member

mtrezza commented Sep 10, 2024

Superseded by #148

@mtrezza mtrezza closed this Sep 10, 2024
@cbaker6 cbaker6 mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtguenther @mtrezza