Direct Access to parse-server #2316

flovilmart · 2016-07-18T18:22:00Z

This PR enables direct access to parse-server, when using the JS SDK from the current node runtime.

All API calls from the JS-SDK are router through route matching (but /functions/:functionName)

Enable that feature by setting PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS=1

flovilmart · 2016-07-18T22:48:06Z

spec/PushController.spec.js

+        expect(pushStatus.get('status')).toBe('failed');
+        done();
+      });
+     }, 500);


Need to add some delay here as with DIRECT_ACCESS the status is not updated upon failure...

flovilmart · 2016-07-20T14:18:47Z

Closing for now as will rebase when #2346 is merged

andrewimm · 2016-07-20T18:12:51Z

This sounds like a great approach. I'll be sure to review when you reopen.

flovilmart · 2016-07-20T18:13:45Z

If you have time to review #2346 I can get going, I'd like to have that merge pretty soon

ghost · 2016-07-20T19:26:50Z

@flovilmart updated the pull request.

flovilmart · 2016-07-20T19:27:50Z

@andrewimm I just reopened it, and tweaked a few parts to make it nicer.

codecov-io · 2016-07-20T19:35:17Z

Current coverage is 92.16% (diff: 90.83%)

Merging #2316 into master will increase coverage by 0.05%

@@             master      #2316   diff @@
==========================================
  Files           100        101     +1   
  Lines         12282      12358    +76   
  Methods        1522       1542    +20   
  Messages          0          0          
  Branches       2020       2035    +15   
==========================================
+ Hits          11313      11390    +77   
+ Misses          969        968     -1   
  Partials          0          0

Powered by Codecov. Last update 5676a6f...e3098fc

ghost · 2016-07-20T20:00:57Z

@flovilmart updated the pull request.

ghost · 2016-07-20T20:22:51Z

@flovilmart updated the pull request.

ghost · 2016-08-20T17:01:51Z

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @acinader as a potential reviewer. Could you take a look please or cc someone with more context?

acinader · 2016-08-20T17:10:37Z

spec/CloudCodeLogger.spec.js

@@ -3,55 +3,55 @@ var LoggerController = require('../src/Controllers/LoggerController').LoggerCont
 var FileLoggerAdapter = require('../src/Adapters/Logger/FileLoggerAdapter').FileLoggerAdapter;

 describe("Cloud Code Logger", () => {


just outta curiosity, why the change here? it looks to me like you are just swapping the order of two tests? or am i missing something else...

acinader · 2016-08-20T17:16:36Z

The bot asked me to look, so I'm looking. Not really adding any value at pr's (yet), but good to read the code.

My big question on this one is "why?". Would be helpful to me, though not necessarily helpful to the code review, if you could give me a use case to understand what is going on.

acinader · 2016-08-20T17:30:43Z

src/DirectRESTController.js

+        query = data;
+      }
+
+      logRequest("internal"+path, method, data, {});


add ' ' around +, or better yet, use template

acinader · 2016-08-20T17:37:30Z

ok, i reviewed it, but since i don't really understand what is going on, its only of value to me, not you ;).

zleman1593 · 2016-08-22T17:19:43Z

@flovilmart Are you planning on merging this soon? Looking forward to it.

flovilmart · 2016-08-22T19:45:52Z

Not soon, it needs some rebase as well as fine tuning for cloud code usage. Mostly a custom UserController for the Parse SDK.

flovilmart · 2016-09-03T14:08:24Z

@andrewimm if you got a minute to check that out again, see if there is anything that could be improved here.

ghost · 2016-09-03T20:15:20Z

@flovilmart updated the pull request - view changes

ghost · 2016-09-03T20:16:51Z

@flovilmart updated the pull request - view changes

flovilmart · 2016-09-03T20:17:29Z

Fixes #1495

When using the DirectRestController, the sessionToken won't be created when saving a new user.

acinader · 2016-09-06T22:24:02Z

@flovilmart I did get around to getting set up and running the alpha tag, but I haven't had a chance to run through some of the account creation, editing, cloud code, tests that I want to do. Another day or two. But no issues in my very casual testing this weekend.

flovilmart · 2016-09-06T23:35:05Z

Alright that's good to hear! As long as you don't use Parse.User.currentUser() and Parse.Cloud.useMasterKey() that should be fine.

On another note, the installationId for the requests are 'cloud' so we don't generate sessionTokens. I believe it should have very little effet on your code.

Or maybe I should support passing installationId as a param. I'm not sure. @andrewimm what do you think?

flovilmart · 2016-09-09T18:35:02Z

@acinader any update on your side?

drew-gross · 2016-09-09T18:51:50Z

If this passes tests I'd be fine with skipping the experimental flag stage. We have a pretty comprehensive test suite, it would be pretty tough to make an implementation that passes tests but still has major issues.

acinader · 2016-09-09T20:57:40Z

👍 we ran two releases through qa with alpha on our dev boxes. one with direct on and one with it off. I wanted to do ~~better~~ any profiling to see impact, but that's still gotta wait.

@flovilmart sorry for delay.

flovilmart · 2016-09-09T21:32:25Z

It's gonna be in the next release, 2.2.19, still marked as experimental until we have a better idea on how to make sure it works 💯

So you'll be able to go back to the regular release cycle with the experimental flag on

listingboat · 2016-10-13T20:10:50Z

@flovilmart So, this is in the current version as experimental. I turned on PARSE_SERVER_ENABLE_EXPERIMENTAL_DIRECT_ACCESS on our Heroku instance and saw faster performance, but also some issues. Our app is a cloud code web app hosted on Heroku.

I noticed in above comments:
"As long as you don't use Parse.User.currentUser() and Parse.Cloud.useMasterKey() that should be fine."

Why is that? We do use Parse.Cloud.useMasterKey to update Users. I can dig further if needed.

flovilmart · 2016-10-13T21:25:12Z

you should not use Parse.Cloud.useMasterKey() at all.

Instead use:

user.save(null, {useMasterKey: true})

nitrag · 2017-03-31T03:08:32Z

What's the status on this feature in terms of it becoming the standard? I don't see any recent Issues. Is it safe to say it's production ready?

flovilmart · 2017-03-31T11:20:34Z

We need to revamp some tests but yes, we can probably make it mainline.

mtrezza · 2020-04-21T23:35:30Z

This looks like a PR that would give a significant performance improvement without any breaking changes.

@acinader This is feature flagged in master, but not currently further looked at and not considered save for production, right?

acinader · 2020-04-21T23:38:27Z

I'm the wrong person to ask. I don't use it in production. @dplewis or @davimacedo might have a better idea of what is outstanding to make this the default.

mtrezza · 2020-04-22T02:40:00Z

I just realized that there is a newer thread from 2019. #5442 I'll ask from there.

ghost added the GH Review: review-needed label Jul 18, 2016

flovilmart force-pushed the DirectRESTController branch from 24c55e6 to ea33ef6 Compare July 18, 2016 21:14

flovilmart added the reviewer-merge label Jul 18, 2016

flovilmart reviewed Jul 18, 2016
View reviewed changes

flovilmart assigned andrewimm Jul 20, 2016

flovilmart mentioned this pull request Jul 20, 2016

Promise router improvements #2346

Closed

flovilmart closed this Jul 20, 2016

flovilmart reopened this Jul 20, 2016

flovilmart force-pushed the DirectRESTController branch from ec2778d to 3eafa04 Compare July 20, 2016 20:22

flovilmart added this to the 2.3.0 milestone Jul 23, 2016

flovilmart mentioned this pull request Aug 16, 2016

Unable to obtain > 40 RPS after migrating to our own Parse server #2030

Closed

acinader reviewed Aug 20, 2016
View reviewed changes

flovilmart added 3 commits September 3, 2016 16:16

Adds ParseServerRESTController experimental support

543224e

Adds basic tests

759fa1a

Do not create sessionToken when requests come from cloudCode #1495

e3098fc

flovilmart force-pushed the DirectRESTController branch from b5cc314 to e3098fc Compare September 3, 2016 20:16

zingano mentioned this pull request Sep 6, 2016

Parse Server much slower than Parse.com with same database #2654

Closed

flovilmart modified the milestones: 2.2.19, 2.3.0 Sep 9, 2016

drew-gross added GH Review: accepted and removed GH Review: review-needed labels Sep 9, 2016

flovilmart merged commit cb7b549 into master Sep 9, 2016

flovilmart deleted the DirectRESTController branch September 9, 2016 19:18

lacker unassigned andrewimm Apr 5, 2017

mtrezza mentioned this pull request Apr 22, 2020

Enable direct access by default #6636

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Direct Access to parse-server #2316

Direct Access to parse-server #2316

flovilmart commented Jul 18, 2016

flovilmart Jul 18, 2016

flovilmart commented Jul 20, 2016

andrewimm commented Jul 20, 2016

flovilmart commented Jul 20, 2016

ghost commented Jul 20, 2016

flovilmart commented Jul 20, 2016

codecov-io commented Jul 20, 2016 •

edited

Loading

ghost commented Jul 20, 2016

ghost commented Jul 20, 2016

ghost commented Aug 20, 2016

acinader Aug 20, 2016

acinader commented Aug 20, 2016

acinader Aug 20, 2016

acinader commented Aug 20, 2016

zleman1593 commented Aug 22, 2016

flovilmart commented Aug 22, 2016

flovilmart commented Sep 3, 2016

ghost commented Sep 3, 2016

ghost commented Sep 3, 2016

flovilmart commented Sep 3, 2016 •

edited

Loading

acinader commented Sep 6, 2016

flovilmart commented Sep 6, 2016 •

edited

Loading

flovilmart commented Sep 9, 2016

drew-gross commented Sep 9, 2016

acinader commented Sep 9, 2016

flovilmart commented Sep 9, 2016

listingboat commented Oct 13, 2016

flovilmart commented Oct 13, 2016

nitrag commented Mar 31, 2017

flovilmart commented Mar 31, 2017

mtrezza commented Apr 21, 2020 •

edited

Loading

acinader commented Apr 21, 2020

mtrezza commented Apr 22, 2020

		@@ -3,55 +3,55 @@ var LoggerController = require('../src/Controllers/LoggerController').LoggerCont
		var FileLoggerAdapter = require('../src/Adapters/Logger/FileLoggerAdapter').FileLoggerAdapter;

		describe("Cloud Code Logger", () => {

Direct Access to parse-server #2316

Direct Access to parse-server #2316

Conversation

flovilmart commented Jul 18, 2016

flovilmart Jul 18, 2016

Choose a reason for hiding this comment

flovilmart commented Jul 20, 2016

andrewimm commented Jul 20, 2016

flovilmart commented Jul 20, 2016

ghost commented Jul 20, 2016

flovilmart commented Jul 20, 2016

codecov-io commented Jul 20, 2016 • edited Loading

Current coverage is 92.16% (diff: 90.83%)

ghost commented Jul 20, 2016

ghost commented Jul 20, 2016

ghost commented Aug 20, 2016

acinader Aug 20, 2016

Choose a reason for hiding this comment

acinader commented Aug 20, 2016

acinader Aug 20, 2016

Choose a reason for hiding this comment

acinader commented Aug 20, 2016

zleman1593 commented Aug 22, 2016

flovilmart commented Aug 22, 2016

flovilmart commented Sep 3, 2016

ghost commented Sep 3, 2016

ghost commented Sep 3, 2016

flovilmart commented Sep 3, 2016 • edited Loading

acinader commented Sep 6, 2016

flovilmart commented Sep 6, 2016 • edited Loading

flovilmart commented Sep 9, 2016

drew-gross commented Sep 9, 2016

acinader commented Sep 9, 2016

flovilmart commented Sep 9, 2016

listingboat commented Oct 13, 2016

flovilmart commented Oct 13, 2016

nitrag commented Mar 31, 2017

flovilmart commented Mar 31, 2017

mtrezza commented Apr 21, 2020 • edited Loading

acinader commented Apr 21, 2020

mtrezza commented Apr 22, 2020

codecov-io commented Jul 20, 2016 •

edited

Loading

flovilmart commented Sep 3, 2016 •

edited

Loading

flovilmart commented Sep 6, 2016 •

edited

Loading

mtrezza commented Apr 21, 2020 •

edited

Loading