Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise router improvements #2346

Closed
wants to merge 3 commits into from
Closed

Conversation

flovilmart
Copy link
Contributor

Extraction of ideas from #2316

  • Use express.Router.Layer to match routes (more generic and robust)
  • Abstracts the batch requests
  • Extracts the sensitiveLogger from PromiseRouter
  • Reduces code paths in PromiseRouter

@codecov-io
Copy link

codecov-io commented Jul 20, 2016

Current coverage is 92.04%

Merging #2346 into master will increase coverage by 0.23%

@@             master      #2346   diff @@
==========================================
  Files            94         95     +1   
  Lines         10479      10463    -16   
  Methods        1275       1282     +7   
  Messages          0          0          
  Branches       1713       1710     -3   
==========================================
+ Hits           9621       9631    +10   
+ Misses          858        832    -26   
  Partials          0          0          

Powered by Codecov. Last updated by ab3b4ad...fb81246

@ghost
Copy link

ghost commented Jul 20, 2016

@flovilmart updated the pull request.

@ghost
Copy link

ghost commented Jul 20, 2016

@flovilmart updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants