feat(PSG-4773): removed conditional request style from credential reg…

…istration (#19)
passageidentity · Sep 20, 2024 · 21393c5 · 21393c5
1 parent da8b492
commit 21393c5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 29 deletions.
diff --git a/Sources/Passage/interfaces/PassageCurrentUser.swift b/Sources/Passage/interfaces/PassageCurrentUser.swift
@@ -170,8 +170,7 @@ final public class PassageCurrentUser {
             let authController = PasskeyAuthenticationController()
             let credential = try await authController.requestPasskeyRegistration(
                 registrationRequest: registrationRequest,
-                includeSecurityKeyOption: includeSecurityKeyOption,
-                autoUpgradeAccount: options?.isConditionalMediation == true
+                includeSecurityKeyOption: includeSecurityKeyOption
             )
             // Send the new Credential Handshake Response to Passage server
             let finishRequest = RegisterWebAuthnFinishRequest(

diff --git a/Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift b/Sources/Passage/services/passkeyAuthentication/PasskeyAuthorizationController.swift
@@ -12,31 +12,17 @@ internal class PasskeyAuthenticationController:
 
     internal func requestPasskeyRegistration(
         registrationRequest: PasskeyRegistrationRequest,
-        includeSecurityKeyOption: Bool = false,
-        autoUpgradeAccount: Bool = false
+        includeSecurityKeyOption: Bool = false
     ) async throws -> ASAuthorizationPublicKeyCredentialRegistration {
         let publicKeyCredentialProvider = ASAuthorizationPlatformPublicKeyCredentialProvider(
             relyingPartyIdentifier: registrationRequest.relyingPartyIdentifier
         )
-        var platformRegistrationRequest = publicKeyCredentialProvider
+        let platformRegistrationRequest = publicKeyCredentialProvider
             .createCredentialRegistrationRequest(
                 challenge: registrationRequest.challenge,
                 name: registrationRequest.userName,
                 userID: registrationRequest.userId
             )
-        #if os(iOS) || os(macOS) || os(visionOS)
-        if #available(iOS 18.0, macOS 15.0, visionOS 2.0, *) {
-            if autoUpgradeAccount {
-                platformRegistrationRequest = publicKeyCredentialProvider
-                    .createCredentialRegistrationRequest(
-                        challenge: registrationRequest.challenge,
-                        name: registrationRequest.userName,
-                        userID: registrationRequest.userId,
-                        requestStyle: .conditional
-                    )
-            }
-        }
-        #endif
         // To match other webauthn "cross-platform" behaviors, we always include a Platform provider
         // request, never JUST a Security Key provider request.
         var requests: [ASAuthorizationRequest] = [ platformRegistrationRequest ]

diff --git a/Sources/Passage/services/passkeyAuthentication/PasskeyCreationOptions.swift b/Sources/Passage/services/passkeyAuthentication/PasskeyCreationOptions.swift
@@ -7,18 +7,8 @@ public struct PasskeyCreationOptions {
     /// Set to `.crossPlatform` to provide option for user  to store credential on a physical Security Key.
     public let authenticatorAttachment: AuthenticatorAttachment?
 
-    /// Set to `true` to create a passkey without asking the user.
-    ///
-    /// NOTE: Only available on iOS 18.0+, macOS 15.0+, and visionOS 2.0+.
-    public let isConditionalMediation: Bool?
-
-    public init(authenticatorAttachment: AuthenticatorAttachment?, isConditionalMediation: Bool?) {
+    public init(authenticatorAttachment: AuthenticatorAttachment?) {
         self.authenticatorAttachment = authenticatorAttachment
-        if #available(iOS 18.0, macOS 15.0, visionOS 2.0, *) {
-            self.isConditionalMediation = isConditionalMediation
-        } else {
-            self.isConditionalMediation = false
-        }
     }
 
 }