Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed conditional request style from credential registration #19

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rickycpadilla
Copy link
Collaborator

@rickycpadilla rickycpadilla commented Sep 19, 2024

What's New?

Removed conditional request style from credential registration.
Reasons:

  • only supported in Xcode 16 and newer (which is only days old)
  • to match registration options on other Passage client sdks

Screenshots (if appropriate):

NA

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jira Ticket

Please add the Jira ticket number and link.

@rickycpadilla rickycpadilla requested a review from a team as a code owner September 19, 2024 21:01
Copy link

sonarcloud bot commented Sep 19, 2024

@rickycpadilla rickycpadilla merged commit 21393c5 into main Sep 20, 2024
3 checks passed
@rickycpadilla rickycpadilla deleted the PSG-4773-xcode14-compatibility branch September 20, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants