feat: pass custom ICE ufrag and pwd as local description init #1207
Conversation
achingbrain
force-pushed
the
feat/allow-overriding-ice-ufrag-and-pwd2
branch
from
4b5ecb0
to
ba4903f
Compare
|
This is failing because although libjuice % git log --graph
// snip
* commit 52e9857a2110594f859cf5ec9c6f7637bf0c49e6
|\ Merge: 3a121cb 2de3524
| | Author: Paul-Louis Ageneau <[email protected]>
| | Date: Tue May 14 11:14:33 2024 +0200
| |
| | Merge branch 'v1.4'
| |
| * commit 2de35247f0b15fa385406f3e2020d0e3d4d5cfcc (tag: v1.4.2) <----- release
| | Author: Paul-Louis Ageneau <[email protected]>
| | Date: Tue May 14 11:11:09 2024 +0200
| |
| | Bumped version to 1.4.2
| |
* | commit 3a121cb157acda28c3735070af72f2e2f5f9651c <----- not on the release branch
|\ \ Merge: 9d35168 237697f
| |/ Author: Paul-Louis Ageneau <[email protected]>
|/| Date: Tue May 14 11:03:56 2024 +0200
| |
| | Merge pull request #243 from xicilion/master
| |
| | Add support for setting ICE ufrag and pwd
| |
// snip@paullouisageneau could you release a new |
There was a problem hiding this comment.
Thank you for adding the local description init parameter. I'll release libjuice 1.4.3 with paullouisageneau/libjuice#243.
|
@paullouisageneau I switched the submodule here to use libjuice master to ensure CI passes, it looks good - I can switch it to 1.4.3 when you get a chance to release it. |
|
@achingbrain I released libjuice v1.5.0 which includes paullouisageneau/libjuice#243 and I updated the submodule on libdatachannel |
Adds an optional second argument to `rtc::PeerConnection::setLocalDescription` that can contain an ICE ufrag and pwd that if passed will be used in place of the randomly generated versions. Refs: paullouisageneau#1166 Refs: paullouisageneau#1201 (comment) Co-authored-by: Paul-Louis Ageneau <[email protected]>
achingbrain
force-pushed
the
feat/allow-overriding-ice-ufrag-and-pwd2
branch
from
ad75e70
to
264585c
Compare
Adds an optional second argument to
rtc::PeerConnection::setLocalDescriptionthat can contain an ICE ufrag and pwd that if passed will be used in place of the randomly generated versions.Refs: #1166
Refs: #1201 (comment)